Track page visit duration #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a no-op constructor for unit testing in net8.0. - Introduced `_pageVisitTimeTracking` to replace `_lastPageAppearing`. - Modified `OnAppearing` and `OnDisappearing` methods for improved page visit duration tracking. - Replaced `TrackPageViewAsync` with `TrackPageVisitTime` to log page visit times. - Updated `IInsightsProvider` interface to include the new tracking method. - Made various formatting and null-checking improvements.
Updated `TrackPageVisitTime` to accept `pageFullName` and `pageDisplayName` parameters for improved telemetry. Modified the `IInsightsProvider` interface to reflect these changes and added XML documentation for better readability. Removed the `duration` parameter from `TrackPageViewAsync` to simplify its signature. Updated the properties dictionary in `ApplicationInsightsProvider` to utilize the new parameters for more informative tracking.
- Updated `ApplicationInsightsProvider` to change the key for page URL and consolidate metrics into a single "Duration" metric. - Modified `IInsights` interface to remove `duration` from `TrackPageViewAsync` and added `TrackPageVisitTime` method. - Adjusted `Insights` class to reflect interface changes and implemented `TrackPageVisitTime`. - Improved formatting in `HasCrashed`, `SendCrashes`, and `ResetCrashes` methods for better readability.
Updated the `OnDisappearing` method in the `ApplicationInsightsProvider` class to use an index-based approach for retrieving the last page added. This change replaces the nullable tuple logic with `FindLastIndex`, improving efficiency by directly manipulating the list. The method now returns early if no last page is found, and the duration calculation is adjusted accordingly.
IeuanWalker
commented
Feb 12, 2025
| { "Duration", pageVisitTime } | ||
| }; | ||
|
|
||
| Client.TrackEvent("PageVisitTime", properties, metrics); |
There was a problem hiding this comment.
@dhindrik I've mostly copied what MS has done in their react library, the main difference is they are using TrackMetric whereas I've used TrackEvent, with custom metric parameters.
TrackMetric can be used instead just by doing this -
Client.TrackMetric("PageVisitTime", pageVisitTime, properties);I decided not to do this, due to the comment on the TrackMetric method. As I haven't used metrics before I thought it be safer to stick with events, but feel free to change it to TrackMetric instead (I'm just not sure about the ramifications of it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A New custom event called
PageVisitTimewas added, with custom metrics added for theDurationin milliseconds.In application insights, the new event looks like this -
This fixes the timeline history of events,
Page Viewis tracked as the page loads andPageVisitTimeis tracked as the user leaves the page -#48