Fixed ClientOsVersion

dhindrik · Sep 3, 2024 · 9104078 · 9104078
1 parent 4d5b552
commit 9104078
Showing 1 changed file with 26 additions and 1 deletion.
diff --git a/TinyInsights.Web/Services/Models/ErrorItem.cs b/TinyInsights.Web/Services/Models/ErrorItem.cs
@@ -12,7 +12,32 @@ public ErrorItem(Dictionary<string, string?> data)
     public string? ClientType => GetData("client_Type");
     public string? ClientModel => GetData("client_Model");
     public string? ClientOs => GetData("client_OS");
-    public string? ClientOsVersion => GetData("OperatingSystemVersion") ?? GetData("client_Browser");
+    public string? ClientOsVersion 
+    { 
+        get
+        {
+            var os = GetData("OperatingSystemVersion"); 
+
+            if(os!= null)
+            {
+                return os;
+            }
+
+            // For android it can be forexample Android 14.
+            var browser = GetData("client_Browser");
+
+            if(browser != null)
+            {
+                var split = browser.Split(" ");
+                if(split.Length > 1 && double.TryParse(split[1], out var version))
+                {
+                    return version.ToString();
+                }
+            }
+
+            return null;
+        }
+    }
     public string? ClientCity => GetData("client_City");
     public string? ClientState => GetData("client_StateOrProvince");
     public string? ClientCountry => GetData("client_CountryOrRegion");