Skip to content

Fixing the typechecking rule for Optional + with ? #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fixing the typechecking rule for Optional + with ? #2650

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
87edc86
Fixing the typesetting rule
winitzki Mar 12, 2025
e823389
Merge branch 'main' into feature/issue-2597-regression-with
winitzki Mar 12, 2025
215d4d1
remove extraneous comment and refactor
winitzki Mar 12, 2025
3ad8f58
Revert "remove extraneous comment and refactor"
winitzki Mar 12, 2025
5651b80
revert refactor as it fails
winitzki Mar 12, 2025
4d11078
Merge branch 'main' into feature/issue-2597-regression-with
winitzki May 7, 2025
0d144f6
bump ci
winitzki May 7, 2025
d00f916
bump ci
winitzki May 8, 2025
369c32e
bump ci
winitzki May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dhall/src/Dhall/TypeCheck.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,12 +1314,21 @@ infer typer = loop

VOptional _O' -> do
case ks of
WithQuestion :| _ -> do

-- (Some x) with ? = v is valid iff the type of x is the same as the type of v.
WithQuestion :| [] -> do
tV' <- loop ctx v
if Eval.conv values _O' tV'
then return (VOptional _O')
else die OptionalWithTypeMismatch

-- (Some x) with ?.a.b = v is valid iff the type of x.a.b is the same as the type of v.
WithQuestion :| k₁ : ks' -> do
tV' <- with _O' (k₁ :| ks') v
if Eval.conv values _O' tV'
then return (VOptional _O')
else die OptionalWithTypeMismatch

WithLabel k :| _ -> die (NotAQuestionPath k)

_ -> die (NotWithARecord e₀ (quote names tE')) -- TODO: NotWithARecordOrOptional
Expand Down
Loading