wpc_lwo: LWO3 Import #609
Merged
wpc_lwo: LWO3 Import #609
+1,229
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgud
reviewed
Feb 25, 2025
Comment on lines
101
to
104
| -define(UW, :16/?UINT). | ||
| -define(FLT, :32/big-float). | ||
| -define(FLT8, :64/big-float). | ||
| -define(ID, :4/bytes). |
There was a problem hiding this comment.
Nitpick, I would prefer if you removed the : from the macros, I don't like Var?Macro constructs, I think Var:?Macro is better.
So the macro is its own entity.
dgud
approved these changes
Feb 25, 2025
|
Hello dgud, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the lwo plugin:
LWO3 import added.
LWOB import also added since it seems a much simpler file format
LWO2 import got improvements (added texture support, more material attributes, UV, color attributes)
LXOB was not changed much but was tested to make sure it still works.
NOTE: Improved lwo importer, added LWO3