-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to appdata for v2.4 #605
Conversation
Thanks for that @elblake |
You're welcome @Micheus You'll need to change the JSON so the new wings.appdata.xml can be seen. You can add as appdata.patch, same folder as com.wings3d.WINGS.json: Reference the patch in JSON sources (only temporary it can be removed for the next version): "sources": [
{
"type": "git",
"url": "https://github.com/dgud/wings.git",
"tag": "v2.4",
"commit": "c17b3d964ec970eed1f015997bb0c4eba0ccff45"
- }
+ },
+ {
+ "type": "patch",
+ "path": "appdata.patch"
+ }
] |
@elblake, I'm a little confused here. I saw you made the changes to wings.appdata.xml, but that didn't reflected in Flahub validating our flatpak. Now you added this info here I thing it can make sense, but I'm still not sure about the way to reference the updated "/unix/wings.appdata.xml". I'm not expert in Linux, so please make this easy to me. 😃 |
@Micheus Sorry it took a bit of time to reply back. The wings.appdata.xml that's been merged this pull request will be reflected when making the next version of the flatpak later on (v2.5). The patch file is the same changes to wings.appdata.xml but is like its own "branch" after commit c17b3d9.. to just patch the small change for this time only. The patch file was made using "git diff".
|
Lets make a new version for flatpak, we add that to appdata file. |
I also think it will be better. Thanks. |
I have prepared for a new release, I've pushed a v2.4.1 tag. |
Updated appdata.xml to fix some errors of the flatpak lint