fix(cache): make updating the max cost of posting cache work again #9526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xqqp
force-pushed
the
fix_updating_max_cost
branch
from
ac00282 to
9e1fba4
Compare
xqqp
force-pushed
the
fix_updating_max_cost
branch
from
9e1fba4 to
7a51a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the max cost of the posting list cache is not wired up. It just calls an empty function. This PR adds a method to
MemoryLayer, that allows updating the max cost of its cache. The old function is deleted and the function call is replaced with a call to the new method.