Skip to content

Optimization of D3 calculation#172

Merged
awvwgk merged 2 commits intodftd3:mainfrom
awvwgk:opt
Mar 27, 2026
Merged

Optimization of D3 calculation#172
awvwgk merged 2 commits intodftd3:mainfrom
awvwgk:opt

Conversation

@awvwgk
Copy link
Copy Markdown
Member

@awvwgk awvwgk commented Mar 27, 2026

  • move redundant calculations out of inner loops
  • additional caching in ASE calculator to avoid object reconstruction
  • match default in Python API with CLI to require opt-in for ATM

Closes #171

- move redundant calculations out of inner loops
- additional caching in ASE calculator to avoid object reconstruction
- match default in Python API with CLI to require opt-in for ATM
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.84%. Comparing base (87efc01) to head (fe758db).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/dftd3/ase.py 66.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   65.78%   65.84%   +0.05%     
==========================================
  Files          34       34              
  Lines        4782     4793      +11     
  Branches     1668     1670       +2     
==========================================
+ Hits         3146     3156      +10     
  Misses        683      683              
- Partials      953      954       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@awvwgk awvwgk merged commit a9b90a0 into dftd3:main Mar 27, 2026
27 checks passed
@awvwgk awvwgk deleted the opt branch March 27, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python dftd3 can be as fast as the binary s-dftd3?

1 participant