Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): new test for toggling tokens #4248
base: main
Are you sure you want to change the base?
test(e2e): new test for toggling tokens #4248
Changes from 10 commits
c26f0ce
9382de0
6440a56
6c9cc5a
7a4e16d
ec1c592
75086da
8fd4bf1
e18e967
3e9d4f4
6dfb8de
ae71644
22fb6d1
3ba2520
4b2aa73
2aa6a3d
4b6cde7
2dff75a
95ba7fd
ab5133c
ec90e9e
120b109
650ca4d
ad9ef6b
d326579
b8ab32d
374e8b6
f52deed
2d2ff6f
590c5ac
6e98b84
759426e
309b973
172ee41
c86a6bd
9915fd3
6d409f8
b12e10c
2a6d7b6
6aa16da
6dc1345
c82b0b8
4c5e2a8
c9fda31
6529980
7e0ba7f
1055747
69f0a9d
9a2ca99
cb9b2fe
9862cf8
7d1dcf9
c9d8981
565d2d0
70c46ef
3be74a1
c71377e
4837741
084334a
1f2edb9
d1ea21d
ba8801d
95f6466
8d1e07d
0eaa956
d9acef7
9df9c6e
34e8466
d1472f0
b844c75
6456ce3
7a73f99
247c22b
7fd8361
c7c6cfb
fb28d87
b83d0a4
b155bbc
5eac618
99d50c0
8bb2311
971b75d
764c91d
e8c68a1
4d3d7ff
28491ab
4886ae1
788cc6b
a0e8443
30245c9
0dcea0b
6cb7896
a86dd02
d8e6489
a877ee9
bc2d905
0fcdc8c
dd1e079
2d264d1
c143c16
2f60ae1
7783eaf
f80f8b2
6b21b4f
0aefd40
0636adf
cf89963
0dbcef1
a555243
c662087
ac0ab18
58c74cb
d67df52
c8a6497
2c72c1a
651253c
63d998b
1086eff
f7285e8
f0b3e36
4336d45
9c221a2
392246d
3c3262d
e517deb
95b008f
9ba97aa
21931ba
c7d2d90
2610b2f
3aad6f2
40ec9b9
376a512
ba48a32
a6bbf79
9836554
41063fd
5e370f3
53fdb6e
01c46f4
1d7809e
e591e27
c4c555c
c1ab9fe
b391219
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this PR, but isn't it better to include
inside
await homepageLoggedIn.takeScreenshot();
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summarized comment instead of multiple short ones
Snapshots: Totally agree, I remembered that you told me you want snapshots in every test so I made it for disable too. But me personally I would leave it out aswell. Expect already tests if it is disabled.
Naming Suggestions: Agree with all of them, makes sense.
adjust takeScreenshot method: Not suggested, setCarouselFirstSlide is only relevant on homepage. Otherwise it could return errors when carousel is not visible.