Add identity to local storage if missing after adding an access method #3505
+110
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that recovered identities are added to the local storage list after adding a new access method (passkey or OpenID), making them easily accessible for future use.
- Introduced a new
addLastUsedIdentityIfMissingmethod that adds identities conditionally without overwriting existing data - Updated access method registration flows to store identity information in local storage
- Refactored the
createPasskeymethod to accept identity name as a parameter instead of reading from store
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| last-used-identities.store.ts | Added addLastUsedIdentityIfMissing method to conditionally add identities to local storage |
| last-used-identities.store.test.ts | Added comprehensive unit tests for the new conditional add method |
| access/+page.svelte | Integrated identity storage after OpenID and passkey registration |
| addAccessMethodFlow.svelte.ts | Refactored createPasskey to accept name parameter and removed store dependency |
| AddAccessMethodWizard.svelte | Added identityName prop and passed it to createPasskey method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...nd/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/+page.svelte
Show resolved
Hide resolved
...nd/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/+page.svelte
Show resolved
Hide resolved
...nd/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/+page.svelte
Show resolved
Hide resolved
sea-snake
reviewed
Nov 19, 2025
...nd/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/+page.svelte
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Identities recovered with the phrase should be easily accessible after recovery.
In this PR, the identity is added to the local storage to be used in the list of existing identities when a new access method is added.
Changes
addLastUsedIdentityIfMissingtolastUsedIdentitiesStore, which adds an identity only if it does not already exist, ensuring that existing data is not overwritten.+page.svelteto useaddLastUsedIdentityIfMissingwhen registering OpenID and passkey access methods, so identities are only added when missing, using accurate timestamps and identity information.nameprop toAddAccessMethodWizard.sveltecomponent.nametocreatePasskeymethod inAddAccessMethodFlowinstead of relying in thelastUsedIdentitiesStore.Tests
addLastUsedIdentityIfMissingto verify that it adds new identities and does not modify existing ones.