Update sns candid files #856
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
yhabib
reviewed
Mar 7, 2025
| @@ -378,6 +384,7 @@ export const fromCandidAction = (action: ActionCandid): Action => { | |||
| return { Motion: action.Motion }; | |||
| } | |||
|
|
|||
| // TODO: Find a better way to log this because JSON.stringify doesn't support BigInt. | |||
There was a problem hiding this comment.
maybe something like:
JSON.stringify(action, (key, value) =>
typeof value === 'bigint' ? value.toString() : value
);
There was a problem hiding this comment.
Looks good, let's do it in a separate pr 👍
There was a problem hiding this comment.
Just sharing if interesting: we already have utils for this.
See jsonReplacer and jsonReviver of @dfinity/utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The SNS Candid types need to be updated to support
SetTopicsForCustomProposals. One SNS has already created a proposal of this type, causing the proposals page for this SNS to break in NNS-dapp. To fix this issue and minimize risks, we are updating only the SNS-related types.Changes
./scripts/import-candid icTests
Todos