feat(localRegistry): expose pod resources #2964
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
Bumps [@babel/runtime-corejs3](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime-corejs3) from 7.22.5 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime-corejs3) --- updated-dependencies: - dependency-name: "@babel/runtime-corejs3" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Francisco Garcia Florez <[email protected]>
Signed-off-by: Francisco Garcia Florez <[email protected]>
Signed-off-by: Francisco Garcia Florez <[email protected]>
Milias
force-pushed
the
add-local-registry-resources
branch
from
e59a093 to
4102245
Compare
Signed-off-by: Francisco Garcia Florez <[email protected]>
Signed-off-by: Francisco Garcia Florez <[email protected]>
Signed-off-by: Francisco Garcia Florez <[email protected]>
Milias
changed the title
|
Before we review, would you mind looking at the errors from the failed check for Lint? https://github.com/devspace-sh/devspace/actions/runs/15261087358/job/43202271440?pr=2964 |
Signed-off-by: Francisco Garcia Florez <[email protected]>
Milias
force-pushed
the
add-local-registry-resources
branch
from
30e1bc1 to
9fc56c1
Compare
Thanks for the heads up! I removed those two unused fields, I had to guess a bit because I couldn't easily run the linter locally. Hopefully that was all :) |
|
Hello! I don't know exactly why there is a failing test, doesn't seem related to changes in the PR. Is there something I could do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)No issue.
Please provide a short message that should be published in the DevSpace release notes
Exposed in the
localRegistryconfiguration resources and annotations of the created Pods.What else do we need to know?
I am not very familiar with go or this codebase, if you have any suggestions please feel free!