Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
devmoath committed Jan 20, 2025
1 parent 9d0bf47 commit 89326ce
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 52 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/formats.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,5 @@ jobs:
- name: Coding Style Checks
run: composer test:lint

- name: Refactor Checks
run: composer test:refactor

- name: Type Checks
run: composer test:types
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
fail-fast: true
matrix:
os: [ubuntu-latest]
php: [8.1, 8.2]
php: [8.1, 8.2, 8.3, 8.4]
stability: [prefer-lowest, prefer-stable]

name: Tests php@${{ matrix.php }} - ${{ matrix.os }} - ${{ matrix.stability }}
Expand Down
8 changes: 1 addition & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@ Run all tests:
composer test
```

Check code quality:

```bash
composer test:refactor
```

Check types:

```bash
Expand Down Expand Up @@ -82,4 +76,4 @@ If you want to check things work against a specific version of PHP, you may incl
docker compose build --build-arg PHP=8.2
```

The default PHP version will always be the lowest version of PHP supported by jira-php.
The default PHP version will always be the lowest version of PHP supported by jira-php.
6 changes: 1 addition & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@
},
"require-dev": {
"laravel/pint": "^1.2.0",
"mockery/mockery": "^1.6",
"nunomaduro/collision": "^7.0.0",
"pestphp/pest": "^2.0.0",
"pestphp/pest-plugin-mock": "^2.0.0",
"phpstan/extension-installer": "^1.2",
"phpstan/phpstan": "^1.8.6",
"phpstan/phpstan-strict-rules": "^1.4",
"rector/rector": "^0.15",
"symfony/var-dumper": "^6.2.0"
},
"autoload": {
Expand Down Expand Up @@ -56,14 +55,11 @@
},
"scripts": {
"lint": "pint --preset laravel -v --ansi",
"refactor": "rector --debug --ansi",
"test:lint": "pint --preset laravel --test -v --ansi",
"test:refactor": "rector --dry-run --ansi",
"test:types": "phpstan analyse --ansi",
"test:unit": "pest --colors=always --min=100 --order-by=random --coverage",
"test": [
"@test:lint",
"@test:refactor",
"@test:types",
"@test:unit"
]
Expand Down
35 changes: 0 additions & 35 deletions rector.php

This file was deleted.

2 changes: 1 addition & 1 deletion src/Jira.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public static function client(string $username, string $password, string $host):

$headers = Headers::withAuthorization(basicAuthentication: $basicAuthentication);

$client = new GuzzleClient();
$client = new GuzzleClient;

$httpTransporter = new HttpTransporter(client: $client, baseUri: $baseUri, headers: $headers);

Expand Down

0 comments on commit 89326ce

Please sign in to comment.