[Fix] #99 — Consolidate duplicate FastAPI app instances and fix metrics route - #129
Open
adarsh-gautam-sys wants to merge 1 commit into
Open
Conversation
…ces and metrics endpoint
|
@adarsh-gautam-sys is attempting to deploy a commit to the devloperdevesh's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/main.pycreated the FastAPI application instance multiple times, registered middlewares across different app instances, and defined the/metricsendpoint twice (once with authentication and once without it). Because Python executes the last definition, the unauthenticated version overrode the authenticated one, and middlewares registered to earlier app instances were lost. This PR consolidates the initialization into a single clean application structure and registers all middlewares and routers correctly.Root Cause
Multiple
FastAPI()instances and duplicate route definitions for/metricsinapp/main.pycaused routing conflicts, discarded middleware registrations, and security bypasses for the metrics endpoint.Changes Made
app = FastAPI(...)call.auth,tenants,documents,rag) cleanly.MetricsMiddleware,LoggingMiddleware,init_redis, andsetup_tracing./metricsendpoint to a single definition requiring admin authentication.Related Issue
Closes #99