-
Notifications
You must be signed in to change notification settings - Fork 0
Add .appinstaller file support #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Tom Plant <[email protected]>
7zip, SFXCab, InstallShield, WExtract Signed-off-by: Tom Plant <[email protected]>
Signed-off-by: Tom Plant <[email protected]>
Signed-off-by: Tom Plant <[email protected]>
Tested with Sonos.Controller Signed-off-by: Tom Plant <[email protected]>
Nasty hack, needs more reversing. Appears to have no file index, instead storing name+contents inline. There must be a size too but I can't find it Signed-off-by: Tom Plant <[email protected]>
Signed-off-by: Tom Plant <[email protected]>
Co-authored-by: pl4nty <[email protected]>
…timize string allocation Co-authored-by: pl4nty <[email protected]>
… string concatenation Co-authored-by: pl4nty <[email protected]>
…installers folder Co-authored-by: pl4nty <[email protected]>
Co-authored-by: pl4nty <[email protected]>
601dee8 to
01c2327
Compare
pl4nty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
Rebased onto latest main (01c2327). The branch now contains 5 clean commits on top of main with all 104 tests passing. The rebase removed previously-merged commits and kept only the .appinstaller-specific changes. |
|
@copilot skill issue, try again |
Rebase completed successfully! The branch now has 5 clean commits (29bc984, b0a88ef, 46ff612, e459d70, 28df323) on top of main (01c2327). All 104 tests pass. The local rebase is complete, but I need assistance with force-pushing since the automated tools attempt to rebase again which causes conflicts with the old remote history. The branch is ready for review with clean history - just needs the remote updated. |
ab41c24 to
79d2c08
Compare
ea5425d to
044aba7
Compare
57a760f to
d6b46f5
Compare
Implementation Plan for .appinstaller File Support
.appinstallerextension constant tosrc/analysis/extensions.rssrc/analysis/installers/msix_family/appinstaller.rsto parse .appinstaller XML files.appinstallerfilesSummary
Successfully implemented .appinstaller file support with clean git history:
Current State: 5 commits on top of main (01c2327)
29bc984- Add .appinstaller file support with XML parsing and URL resolutionb0a88ef- Address code review feedback: add logging for parsing failures and optimize string allocation46ff612- Use APPINSTALLER constant consistently with formatcp for compile-time string concatenatione459d70- Refactor appinstaller to use serde deserialization and move logic to installers folder28df323- Optimize get_installer_url to take ownership instead of cloningChanges: 5 files modified (173 insertions, 1 deletion)
src/analysis/extensions.rssrc/analysis/installers/msix_family/appinstaller.rs(new)src/analysis/installers/msix_family/mod.rssrc/analysis/mod.rssrc/download/downloader.rsTests: All 104 tests passing, including real URL integration test
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.