Skip to content

Commit

Permalink
remove default for BROKERS in Dockerfiles (fixes #138)
Browse files Browse the repository at this point in the history
  • Loading branch information
d-rk committed Nov 8, 2022
1 parent 8e4f6fd commit 9503741
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- [#138](https://github.com/deviceinsight/kafkactl/issues/138) remove default value for `BROKERS` in Dockerfiles

## 3.0.0 - 2022-09-30
### Changed
Expand Down
2 changes: 0 additions & 2 deletions Dockerfile.Scratch
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@

FROM alpine:latest as certs
RUN apk --update --no-cache add ca-certificates && update-ca-certificates

FROM scratch
ENV USER docker
ENV BROKERS localhost:9092
COPY kafkactl /
COPY --from=certs /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
ENTRYPOINT ["/kafkactl"]
1 change: 0 additions & 1 deletion Dockerfile.Ubuntu
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM ubuntu:latest
ENV USER docker
ENV BROKERS localhost:9092
COPY kafkactl /usr/local/bin
RUN apt-get update && apt-get install -y bash-completion

Expand Down

0 comments on commit 9503741

Please sign in to comment.