Fix inverted HTTP status check logic

deviceinsight · Nov 3, 2020 · 3f15816 · 3f15816
1 parent a5cc371
commit 3f15816
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -1,5 +1,9 @@
 = Changelog
 
+== Version 2.7.1
+
+* Fix inverted status check which _fails_ for any 2xx HTTP status
+
 == Version 2.7.0
 
 * Accept any 2xx HTTP status code when deploying Helm charts

diff --git a/src/main/kotlin/com/deviceinsight/helm/DeployMojo.kt b/src/main/kotlin/com/deviceinsight/helm/DeployMojo.kt
@@ -167,7 +167,7 @@ class DeployMojo : AbstractMojo() {
 
 			httpClient.execute(request).use { response ->
 				val statusCode = response.statusLine.statusCode
-				if ( (statusCode >= 200) && (statusCode < 300) ) {
+				if (statusCode < 200 || statusCode >= 300) {
 					throw RuntimeException("Unexpected status code when executing $chartPublishMethod request to " +
 						"chart repo ${chartDeploymentRequest.chartPublishUrl()}: $statusCode")
 				}