build(deps-dev): bump eslint from 9.39.4 to 10.1.0

package.json

@@ -35,13 +35,15 @@
     "ws": "^8.2.1"
   },
   "devDependencies": {
+    "@eslint/js": "^10.0.1",
+    "@types/eslint-scope": "^9.1.0",
     "@types/jest": "^30.0.0",
     "@types/md5": "^2.1.33",
     "@types/node": "^25.0.1",
     "@types/ws": "^8.2.0",
     "babel-loader": "^10.0.0",
     "babel-plugin-transform-remove-console": "^6.9.4",
-    "eslint": "^9.25.1",
+    "eslint": "^10.1.0",
     "eslint-config-prettier": "^10.1.2",
     "filereader": "^0.10.3",
     "jest": "^30.0.0",

src/core/AMTDesktop.ts

@@ -106,7 +106,6 @@ export class AMTDesktop extends Desktop {
     this.onKvmDataPending = []
     this.onKvmDataAck = -1
     this.kvmDataSupported = false
-    // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
     for (const i in this.sparecache) {
       delete this.sparecache[i]
     }

src/core/AMTIDER.ts

@@ -113,7 +113,6 @@ export class AMTIDER {
     this.acc += data
     console.debug(`IDER-ProcessData:  ${this.acc.length}, ${TypeConverter.rstr2hex(this.acc)}`)
     // Process as many commands as possible
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       // checks if the received data contains at least 8 bytes in the header.
       // If not, it returns 0, indicating that there is not enough data to process.
@@ -407,12 +406,10 @@ export class AMTIDER {
     }
     if (fr.readAsBinaryString != null) {
       if (this.g_media != null) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         fr.readAsBinaryString(this.g_media.slice(lba, lba + len))
       }
     } else {
       if (this.g_media != null) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         fr.readAsArrayBuffer(this.g_media.slice(lba, lba + len))
       }
     }

src/core/AMTKvmDataRedirector.ts

@@ -8,7 +8,6 @@ import { type IKvmDataCommunicator } from './Interfaces'
 
 export class AMTKvmDataRedirector extends AMTRedirector implements IKvmDataCommunicator {
   onSendKvmData: (data: string) => void
-  // eslint-disable-next-line @typescript-eslint/no-useless-constructor
   constructor(config: RedirectorConfig) {
     super(config)
   }

src/core/AMTRedirector.ts

@@ -126,7 +126,6 @@ export class AMTRedirector implements ICommunicator {
     // Using this generic signature allows us to pass the WebSocket type from unit tests or in production from a web browser
     this.connectState = 0
     // let ws = new c(this.getWsLocation()) // using create function c invokes the constructor WebSocket()
-    // eslint-disable-next-line new-cap
     this.socket = new c(this.getWsLocation(), this.authToken) // The "p=2" indicates to the relay that this is a REDIRECTION session
     this.socket.onopen = this.onSocketConnected.bind(this)
     this.socket.onmessage = this.onMessage.bind(this)
@@ -342,15 +341,13 @@ export class AMTRedirector implements ICommunicator {
             curptr += noncelen + 1
 
             // QOP
-            let qoplen = 0
             let qop = ''
             const cnonce: string = this.generateRandomNonce(32)
             const snc = '00000002'
             let extra = ''
             if (authType === 4) {
-              qoplen = authDataBuf.charCodeAt(curptr)
+              const qoplen = authDataBuf.charCodeAt(curptr)
               qop = authDataBuf.substring(curptr + 1, curptr + 1 + qoplen)
-              curptr += qoplen + 1
               extra = `${snc}:${cnonce}:${String(qop)} :`
             }
 
@@ -435,7 +432,6 @@ export class AMTRedirector implements ICommunicator {
               TypeConverter.IntToStrX(this.amtSequence++) +
               String.fromCharCode(0x00, 0x00, 0x1b, 0x00, 0x00, 0x00)
           )
-          // eslint-disable-next-line @typescript-eslint/no-implied-eval, @typescript-eslint/no-unsafe-argument
           if (this.protocol === 1) {
             this.amtKeepAliveTimer = setInterval(this.sendAmtKeepAlive.bind(this), 2000)
           }

src/core/Converter.ts

@@ -79,7 +79,6 @@ export const TypeConverter = {
     let r = ''
     if (x !== 0 && (!isTruthy(x) || x == null)) return '(Null)'
     if (x instanceof Array) {
-      // eslint-disable-next-line @typescript-eslint/no-for-in-array
       for (const i in x) {
         r =
           r + '<br />' + String(this.gap(c)) + 'Item #' + String(i) + ': ' + String(this.ObjectToStringEx(x[i], c + 1))
@@ -101,7 +100,6 @@ export const TypeConverter = {
       return '(Null)'
     }
     if (x instanceof Array) {
-      // eslint-disable-next-line @typescript-eslint/no-for-in-array
       for (const i in x) {
         r =
           r + '\r\n' + String(this.gap2(c)) + 'Item #' + String(i) + ': ' + String(this.ObjectToStringEx2(x[i], c + 1))
@@ -150,8 +148,7 @@ export const TypeConverter = {
   // Convert a raw string to a hex string
   rstr2hex(input: string): string {
     let r = ''
-    let i = 0
-    for (i = 0; i < input.length; i++) {
+    for (let i = 0; i < input.length; i++) {
       r = r + String(this.char2hex(input.charCodeAt(i)))
     }
     return r

src/core/IDERDataProcessor.ts

@@ -368,8 +368,8 @@ export class IDERDataProcessor {
     console.debug('SCSI: MODE_SENSE_6', dev)
 
     if (cdb.charCodeAt(2) === 0x3f && cdb.charCodeAt(3) === 0x00) {
-      let a = 0
-      let b = 0
+      let a: number
+      let b: number
       switch (dev) {
         case 0xa0: // DEV_FLOPPY
           if (this.ider.floppy == null) {

src/core/ImageData/DataProcessor.ts

@@ -20,7 +20,6 @@ export class DataProcessor implements IDataProcessor {
   parent: Desktop
   constructor(comm: ICommunicator, parent: Desktop) {
     this.acc = ''
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     this.stateProcessorFac = new StateProcessorFactory(comm, parent, this.updateRFBState.bind(this))
     this.parent = parent
   }
@@ -32,7 +31,7 @@ export class DataProcessor implements IDataProcessor {
   processData(data: string): any {
     if (!isTruthy(data)) return
     this.acc += data
-    let cmdSize = 0
+    let cmdSize: number
     console.debug(`Process Data ACC length:  ${this.acc.length}`)
     while (this.acc.length > 0) {
       const stateProcessor: IStateProcessor = this.stateProcessorFac.getProcessor(this.parent.state)

src/core/ImageData/RLEDecoder.ts

@@ -29,7 +29,7 @@ class RLEDecoder implements IRLEDecoder {
     let runlengthdecode
     const palette: number[] = []
     let rlecount = 0
-    let runlength = 0
+    let runlength: number
     let i: number
     // this.parent.Debug("RECT RLE (" + (datalen - 5) + ", " + subencoding + "):" + rstr2hex(data.substring(21, 21 + (datalen - 5))));
     if (subencoding === 0) {
@@ -45,7 +45,7 @@ class RLEDecoder implements IRLEDecoder {
       ImageHelper.putImage(this.parent, x, y)
     } else if (subencoding === 1) {
       // Solid color tile
-      v = data.charCodeAt(ptr++) + (this.parent.bpp === 2 ? data.charCodeAt(ptr++) << 8 : 0)
+      v = data.charCodeAt(ptr++) + (this.parent.bpp === 2 ? data.charCodeAt(ptr) << 8 : 0)
       this.parent.canvasCtx.fillStyle =
         'rgb(' +
         (this.parent.bpp === 1

src/core/RFBStateProcessors/FrameBufferBellServerCutText.ts

@@ -26,7 +26,7 @@ class FrameBufferBellServerCutText implements IStateProcessor {
   processState(acc: string): number {
     // acc is the accumulated byte encoded string so far
     let cmdsize = 0
-    let len = 0
+    let len: number
     switch (acc.charCodeAt(0)) {
       case 0: // FramebufferUpdate
         if (acc.length < 4) return 0

src/core/RFBStateProcessors/HandshakeState.ts

@@ -21,7 +21,7 @@ class HandshakeState implements IStateProcessor {
 
   processState(acc: string): number {
     // acc is the accumulated byte encoded string so far
-    let cmdSize = 0
+    let cmdSize: number
     if (acc.length >= 12) {
       // Getting handshake & version
       cmdSize = 12

src/core/RFBStateProcessors/SecurityOptions.ts

@@ -20,7 +20,7 @@ class SecurityOptions implements IStateProcessor {
 
   processState(acc: string): number {
     // acc is the accumulated byte encoded string so far
-    let cmdSize = 0
+    let cmdSize: number
     if (acc.length >= 1) {
       // Getting security options
       cmdSize = acc.charCodeAt(0) + 1

src/core/RFBStateProcessors/SecurityResponse.ts

@@ -21,7 +21,7 @@ class SecurityResponse implements IStateProcessor {
 
   processState(acc: string): number {
     // acc is the accumulated byte encoded string so far
-    let cmdSize = 0
+    let cmdSize: number
     if (acc.length >= 4) {
       // Getting security response
       cmdSize = 4

src/core/RFBStateProcessors/ServerInit.ts

@@ -25,7 +25,7 @@ class ServerInit implements IStateProcessor {
 
   processState(acc: string): number {
     // acc is the accumulated byte encoded string so far
-    let cmdSize = 0
+    let cmdSize: number
     if (acc.length >= 24) {
       // Getting server init
 

src/core/Utilities/AMTKeyCodeConverter.ts

@@ -10,7 +10,6 @@ import { isTruthy } from './UtilityMethods'
  */
 export const AMTKeyCodeConverter = {
   convertAMTKeyCode(e: any): any {
-    // eslint-disable-next-line @typescript-eslint/restrict-plus-operands
     if (isTruthy(e.code.startsWith('Key')) && e.code.length === 4) {
       return e.code.charCodeAt(3) + (e.shiftKey === false ? 32 : 0)
     }

src/test/helper/testAmtDesktop2.ts

@@ -109,7 +109,6 @@ class AmtDesktop2 extends Desktop {
     this.onKvmDataPending = []
     this.onKvmDataAck = -1
     this.kvmDataSupported = false
-    // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
     for (const i in this.sparecache) {
       delete this.sparecache[i]
     }

src/test/kvmui.test.ws.ts

@@ -110,7 +110,6 @@ class AmtDesktop extends Desktop {
     this.onKvmDataPending = []
     this.onKvmDataAck = -1
     this.kvmDataSupported = false
-    // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
     for (const i in this.sparecache) {
       delete this.sparecache[i]
     }