Conversation
rsdmike
changed the title
rsdmike
changed the title
There was a problem hiding this comment.
Pull request overview
This PR refactors Go build constraints across platform-specific files, primarily removing legacy // +build directives and normalizing some OS selection expressions.
Changes:
- Removed deprecated
// +build ...lines in multiple Windows/Linux-specific files (relying on//go:build ...only). - Changed several previously-
linuxbuild constraints to!windows(expanding those implementations to all non-Windows OSes).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/windows/setupapi.go | Removes legacy // +build windows directive. |
| pkg/upid/windows.go | Removes legacy // +build windows directive. |
| pkg/upid/windows_test.go | Removes legacy // +build windows directive. |
| pkg/upid/linux.go | Expands build constraint from linux to !windows. |
| pkg/upid/linux_test.go | Removes legacy // +build linux directive. |
| pkg/network/dhcp_windows.go | Removes legacy // +build windows directive. |
| pkg/network/dhcp_linux.go | Removes legacy // +build !windows directive. |
| pkg/heci/windows.go | Removes legacy // +build windows directive. |
| pkg/heci/windows_test.go | Removes legacy // +build windows,amt directive. |
| pkg/heci/linux.go | Expands build constraint from linux to !windows. |
| pkg/heci/linux_test.go | Removes legacy // +build linux,amt directive. |
| pkg/amt/windows.go | Removes legacy // +build windows directive. |
| pkg/amt/linux.go | Expands build constraint from linux to !windows. |
Comments suppressed due to low confidence (1)
pkg/upid/linux.go:1
- The build constraint change from
linuxto!windowsmakes this “Linux UPID client” compile on all non-Windows OSes, but the implementation depends on the Linux HECI/MEI driver (/dev/mei0viaheci.NewDriver()). If non-linux platforms aren’t actually supported, this should stay//go:build linux(or provide a!windows && !linuximplementation that returnsErrUPIDNotSupported).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graikhel-intel
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intentionally expands OS support to support discovery in the future.