refactor: enhance validation for authenticating with console#1235
Merged
refactor: enhance validation for authenticating with console#1235
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the shared server authentication flag handling to improve CLI validation around token-exchange authentication (Console auth), and adds unit tests to lock in the expected behavior.
Changes:
- Updates
ServerAuthFlags.AuthEndpointflag metadata (help text, adds env var support, removes implicit default) and clarifies struct docs. - Adds
ServerAuthFlags.Validate()(Kong validation) to enforce credential presence when--auth-endpointis provided. - Adds unit tests covering
Validate,ValidateRequired, andApplyToRequest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/commands/auth.go |
Adds Kong validation for auth-endpoint usage and updates auth-endpoint flag metadata/documentation. |
internal/commands/auth_test.go |
Introduces tests to validate auth flag behavior and request header application. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rsdmike
force-pushed
the
consoleAuth
branch
2 times, most recently
from
545f5d6 to
e1ebdf8
Compare
graikhel-intel
approved these changes
Mar 31, 2026
auto-merge was automatically disabled
April 2, 2026 18:38
Rebase failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.