feat: add console device registration for local profile activation#1231
Merged
madhavilosetty-intel merged 1 commit intonextfrom Apr 13, 2026
Merged
feat: add console device registration for local profile activation#1231madhavilosetty-intel merged 1 commit intonextfrom
madhavilosetty-intel merged 1 commit intonextfrom
Conversation
madhavilosetty-intel
force-pushed
the
device-registry
branch
3 times, most recently
from
0ed1af2 to
22fd022
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the local profile activation flow to optionally register the device with the Console (when --profile is used locally alongside Console auth flags / --auth-endpoint), and extends local deactivation to optionally delete the device from the Console when auth is provided.
Changes:
- Add “orchestrate with Console” logic to local profile activation, including password resolution, optional Console authentication, device registration, and cleanup on CIRA failure.
- Update local deactivation to preserve an HTTP(S)
--urlfor Console deletion while still executing the local unprovision path, and optionally delete the device from the Console after local deactivation. - Add/extend unit tests for the new activation/deactivation Console behaviors.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/heci/linux.go | Formatting-only change (blank line). |
| internal/rps/rps.go | Formatting-only change (blank line). |
| internal/commands/deactivate.go | Preserve Console URL during --local, pre-resolve GUID, and optionally delete device from Console after local deactivation. |
| internal/commands/deactivate_test.go | Add tests for Console URL preservation, Console deletion behavior, and update mocks for GUID resolution. |
| internal/commands/activate/activate.go | Add local “orchestrate with Console” flow: resolve passwords, optionally authenticate/register device, and update TLS flag resolution. |
| internal/commands/activate/activate_test.go | Update tests for resolveConsoleInfo signature change and add coverage for local Console URL validation + local TLS enforcement. |
| internal/cli/cli_test.go | Formatting-only change (blank line). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
madhavilosetty-intel
force-pushed
the
device-registry
branch
2 times, most recently
from
c944089 to
9ac64ee
Compare
rsdmike
force-pushed
the
device-registry
branch
from
9ac64ee to
22fd022
Compare
rsdmike
force-pushed
the
device-registry
branch
3 times, most recently
from
d495fc5 to
186b3f6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Add orchestrateWithConsole flow so local profile activation (--profile file --auth-endpoint) registers the device with the console.
rsdmike
force-pushed
the
device-registry
branch
from
186b3f6 to
0fb4cb7
Compare
rsdmike
approved these changes
Apr 13, 2026
RosieAMT
pushed a commit
that referenced
this pull request
Apr 13, 2026
# [3.0.0-beta.16](v3.0.0-beta.15...v3.0.0-beta.16) (2026-04-13) ### Features * add console device registration for local profile activation ([#1231](#1231)) ([1ea6567](1ea6567))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add orchestrate With Console flow so local profile activation (--profile file --auth-endpoint) registers the device with the console.