Repository navigation
test: add test around file parsing handling - #129
Merged
Merged
Conversation
Changed the error handling in HarFileRepository::loadJson() to use strict comparison (false === $contents) instead of truthiness check (!$contents). This prevents incorrectly throwing an exception when loading valid empty files. The previous implementation would throw an exception for empty files because an empty string is falsy in PHP, even though file_get_contents() successfully read the file. The new implementation only throws when file_get_contents() actually fails and returns false. Added test coverage for the empty file case to ensure empty files can be loaded without throwing exceptions.
deviantintegral
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.