Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move main plugin class to a PSR-4 file #29

Merged
merged 2 commits into from
May 8, 2024
Merged

Move main plugin class to a PSR-4 file #29

merged 2 commits into from
May 8, 2024

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented May 8, 2024 •
edited
Loading

@HPiirainen Noticed the strange array in PSR-4 autoloading.

@HPiirainen HPiirainen self-assigned this May 8, 2024
HPiirainen
HPiirainen requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@HPiirainen HPiirainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good stuff! If you can move the use statements from the original plugin.php to the new Plugin class, then we're good to go 👍

plugin.php Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the use statements from this class...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 🍏

src/Plugin.php
*/

namespace Geniem\Oopi;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... to this class so everything works correctly 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. This is the first time I use a computer 🙃

@HPiirainen HPiirainen merged commit 5a562e4 into devgeniem:master May 8, 2024
3 checks passed
@szepeviktor szepeviktor deleted the class-move branch May 8, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HPiirainen HPiirainen HPiirainen requested changes

Assignees

@HPiirainen HPiirainen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @HPiirainen