Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calling json_decode with non-string input #25

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fix calling json_decode with non-string input #25

merged 2 commits into from
Feb 6, 2024

Conversation

HPiirainen
Copy link
Contributor 

PHP Deprecated:  json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in wp-oopi/src/Util.php on line 25"

json_decode expects the first parameter to be a string, so let's just return false if the input is not a string.

@HPiirainen HPiirainen requested a review from Liblastic January 29, 2024 16:44
Liblastic
Liblastic approved these changes Jan 31, 2024
View reviewed changes
Copy link

@Liblastic Liblastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@HPiirainen HPiirainen merged commit 454d5fe into master Feb 6, 2024
3 checks passed
@HPiirainen HPiirainen deleted the php8-deprecations branch February 6, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liblastic Liblastic Liblastic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HPiirainen @Liblastic