Release changes for OLM validation

[michael-valdron]

Please specify the area for this PR

registry operator

What does does this PR do / why we need it:

Changes to fix failing OLM validation test cases, required for OperatorHub publication (devfile/api#1211).

Additional changes include:

• The removal of CHANGELOG in favor of using the built-in GitHub release pages that can generate this content
• Addition of addlicense.sh script to insert license headers into new source files
• Update license headers in source files and boilerplate file for source generation to match the license header change in Remove years under registry-operator license header file api#1243

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1251

PR acceptance criteria:

• Change Log
  • Are all your changes documented under the upcoming release entry?
• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
• Gosec scans
  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Patch coverage: 58.16% and project coverage change: +3.17% 🎉

Comparison is base (46fe9e0) 22.72% compared to head (6a8d908) 25.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   22.72%   25.90%   +3.17%     
==========================================
  Files          23       25       +2     
  Lines        1307     1444     +137     
==========================================
+ Hits          297      374      +77     
- Misses        995     1049      +54     
- Partials       15       21       +6     

Files Changed	Coverage Δ
api/v1alpha1/clusterdevfileregistrieslist_types.go	100.00% <ø> (ø)
...i/v1alpha1/clusterdevfileregistrieslist_webhook.go	71.87% <ø> (ø)
api/v1alpha1/devfileregistrieslist_types.go	100.00% <ø> (ø)
api/v1alpha1/devfileregistrieslist_webhook.go	72.72% <ø> (ø)
api/v1alpha1/devfileregistry_types.go	100.00% <ø> (ø)
api/v1alpha1/devfileregistry_webhook.go	60.00% <ø> (ø)
api/v1alpha1/validate.go	93.87% <ø> (ø)
controllers/devfileregistry_controller.go	0.00% <0.00%> (ø)
controllers/ensure.go	0.00% <ø> (ø)
controllers/update.go	0.00% <ø> (ø)
... and 15 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michael-valdron]

/retest

[michael-valdron]

The registry operator also requires its own cert-manager which is not supported by OLM due to it having its own cert management: https://olm.operatorframework.io/docs/advanced-tasks/adding-admission-and-conversion-webhooks/#certificate-authority-requirements

Currently investigating a workaround to operator-framework/operator-lifecycle-manager#1805.

[michael-valdron]

The registry operator also requires its own cert-manager which is not supported by OLM due to it having its own cert management: https://olm.operatorframework.io/docs/advanced-tasks/adding-admission-and-conversion-webhooks/#certificate-authority-requirements

Currently investigating a workaround to operator-framework/operator-lifecycle-manager#1805.

Update: It seems after reviewing this more that issue here is that if we were doing any of the following it would not work with OLM's cert management:

• Need to provide our own certifications
• Mounting the location to store the certifications to a different location from the defaults

We are not currently doing these, only using cert-manager outside OLM. The setup for using OLM's cert manager should be the same as we currently have for cert-manager.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment