Add container resource caps enforcement for workspace containers

[tolusha]

What does this PR do?

Implements ContainerResourceCaps configuration to enforce maximum resource limits and requests for workspace containers. When configured, container resource requirements that exceed the caps will be limited to the maximum values. This feature does not apply to initContainers or projectClone containers.

Assisted-by: Claude.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-9546

Is it tested? How?

1. Create DevWorkspaceOperatorConfig

apiVersion: controller.devfile.io/v1alpha1
config:
  workspace:
    containerResourceCaps:
      limits:
        cpu: "1"
        memory: 2Gi
      requests:
        cpu: "0.1"
        memory: 100Mi
kind: DevWorkspaceOperatorConfig
metadata:
  name: devworkspace-operator-config
  namespace: devworkspace-controller

2. Start a workspace from devifile

3. Check containers resources in a workspace deployment:

• caps applied for tools-1 and tools-2
• no changes for tools-3

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia, tolusha
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[dkwon17]

@tolusha thank you for the PR,

I noticed that if I set for example:

apiVersion: controller.devfile.io/v1alpha1
config:
  workspace:
    containerResourceCaps:
      limits:
        cpu: '102'
        memory: 200Gi
      requests:
        cpu: '102'
        memory: 200Mi
kind: DevWorkspaceOperatorConfig
metadata:
  name: devworkspace-operator-config
  namespace: openshift-operators

And create a devworkspace with no cpu limits or requests:

Devworkspace

apiVersion: workspace.devfile.io/v1alpha2
kind: DevWorkspace
metadata:
  name: devfile
  namespace: admin-devspaces
spec:
  started: true
  template:
    components:
      - container:
          image: 'quay.io/devfile/universal-developer-image:latest'
          memoryLimit: 5Gi
          memoryRequest: 3Gi
          sourceMapping: /projects
        name: tools-2

Then it looks like the cpu: 102 is being applied to the devworkspace:

'Error creating DevWorkspace deployment: Detected unrecoverable event FailedScheduling: 0/1 nodes are available: 1 Insufficient cpu. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod.'

If I update the DWOC to set the cpu limit and request cap to 10, the devworkspace starts, and the container has a limit and request set to 10.

I think the cap should not be applied to the cpu in both cases?