Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memory limit to 5Gi #1346

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Update memory limit to 5Gi #1346

merged 2 commits into from
Nov 7, 2024

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Nov 7, 2024

What does this PR do?

This PR updates the memory limit of the devworkspace-controller container of the devworkspace-controller-manager-* pod from 3Gi to 5Gi.

What issues does this PR fix or reference?

Fixes #1345

Is it tested? How?

To test, run:

DWO_IMG_REPO=quay.io/<username>/<repo>
DWO_IMG_TAG=<tag>
export DWO_BUNDLE_IMG=${DWO_IMG_REPO}/devworkspace-operator-bundle:${DWO_IMG_TAG}
export DWO_INDEX_IMG=${DWO_IMG_REPO}/devworkspace-operator-index:${DWO_IMG_TAG}
export DOCKER=podman 
make generate_olm_bundle_yaml build_bundle_and_index register_catalogsource

And install the operator from OperatorHub.

Verify that the resulting devworkspace-controller-manager-* pod in the openshift-operators namespace has the new memory limit for the devworkspace-controller container.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@openshift-ci openshift-ci bot added the approved label Nov 7, 2024
@dkwon17 dkwon17 changed the title Update memory Update memory limit to 5GI Nov 7, 2024
@dkwon17 dkwon17 changed the title Update memory limit to 5GI Update memory limit to 5Gi Nov 7, 2024
Copy link
Collaborator

@AObuchow AObuchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this @dkwon17 :)
I installed DWO using the PR test instructions on an OCP 4.16 cluster, and the devworkspace-controller-manager deployment & pod had the correct memory limit:

  containers:
    - resources:
        limits:
          cpu: '3'
          memory: 5Gi
        requests:
          cpu: 250m
          memory: 100Mi

Copy link

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit 2303e13 into devfile:main Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase memory limit to 5Gi
2 participants