feat: Use labels on PVCs for better reconciling #1233

mkuznyetsov · 2024-02-14T08:03:21Z

What does this PR do?

Add new labels to indicate PVCs that are in use by Devworkspace Operator.
This allows to trigger workspace reconcile, that must be triggered upon PVC deletion.
and if it's a common PVC that had a name configured by external operator config, only those workspaces that would have the same PVC name should be reconciled

What issues does this PR fix or reference?

#920

Is it tested? How?

Steps to test the new & old behavior with sample DevWorkspaces (DW)

install & run a current version of DWO:

https://github.com/devfile/devworkspace-operator/?tab=readme-ov-file#run-controller-locally

add some Devworkspaces and a devworkspace:

DW with per-user storage

cat <<'EOF' | kubectl apply -n $NAMESPACE -f - 
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: old-dw-per-user
spec:
  started: true
  routingClass: 'basic'
  template:
    components:
      - name: web-terminal
        container:
          image: quay.io/wto/web-terminal-tooling:next
          memoryRequest: 256Mi
          memoryLimit: 512Mi
          mountSources: true
          command:
           - "tail"
           - "-f"
           - "/dev/null"
EOF

DW with per-workspace storage

cat <<'EOF' | kubectl apply -n $NAMESPACE -f - 
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: old-dw-per-workspace
spec:
  started: true
  routingClass: 'basic'
  template:
    attributes:
      controller.devfile.io/storage-type: per-workspace
    components:
      - name: basic-volume
        volume: 
          size: 5Gi
      - name: web-terminal
        container:
          image: quay.io/wto/web-terminal-tooling:next
          memoryRequest: 256Mi
          memoryLimit: 512Mi
          mountSources: true
          command:
           - "tail"
           - "-f"
           - "/dev/null"
EOF

External operator config, that is configured with custom PVC name

cat <<'EOF' | kubectl apply -f - 
apiVersion: controller.devfile.io/v1alpha1
config:
  enableExperimentalFeatures: true
  routing:
    clusterHostSuffix: 192.168.49.2.nip.io
    defaultRoutingClass: basic
  workspace:
    defaultStorageSize:
      common: 6Gi
      perWorkspace: 4Gi
    imagePullPolicy: Always
    pvcName: old-custom-pvc-name
kind: DevWorkspaceOperatorConfig
metadata:
  name: external-config
  namespace: default
EOF

cat <<'EOF' | kubectl apply -n $NAMESPACE -f - 
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: old-dw-per-user-external
spec:
  started: true
  routingClass: 'basic'
  template:
    attributes:
      controller.devfile.io/devworkspace-config:
        name: external-config
        namespace: default
      controller.devfile.io/storage-type: common
    components:
      - name: web-terminal
        container:
          image: quay.io/wto/web-terminal-tooling:next
          memoryRequest: 256Mi
          memoryLimit: 512Mi
          mountSources: true
          command:
           - "tail"
           - "-f"
           - "/dev/null"
EOF

Inspect PVC objects, that are created for these repos.

kubectl describe pvc -n $NAMESPACE | grep "Labels:" -A 3 -B 6

They WILL NOT have the label "controller.devfile.io/devworkspace_pvc_type".
Only per-workspace PVC will have "controller.devfile.io/devworkspace_id" label

build and run a new version of operator from this pull-request:
export NAMESPACE="devworkspace-controler"
...
make run
Create DWs from step TODO:

DW with per-user storage

cat <<'EOF' | kubectl apply -n $NAMESPACE -f - 
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: new-dw-per-user
spec:
  started: true
  routingClass: 'basic'
  template:
    components:
      - name: web-terminal
        container:
          image: quay.io/wto/web-terminal-tooling:next
          memoryRequest: 256Mi
          memoryLimit: 512Mi
          mountSources: true
          command:
           - "tail"
           - "-f"
           - "/dev/null"
EOF

DW with per-workspace storage

cat <<'EOF' | kubectl apply -n $NAMESPACE -f - 
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: new-dw-per-workspace
spec:
  started: true
  routingClass: 'basic'
  template:
    attributes:
      controller.devfile.io/storage-type: per-workspace
    components:
      - name: basic-volume
        volume: 
          size: 5Gi
      - name: web-terminal
        container:
          image: quay.io/wto/web-terminal-tooling:next
          memoryRequest: 256Mi
          memoryLimit: 512Mi
          mountSources: true
          command:
           - "tail"
           - "-f"
           - "/dev/null"
EOF

Another external operator config, that is configured with custom PVC name

cat <<'EOF' | kubectl apply -f - 
apiVersion: controller.devfile.io/v1alpha1
config:
  enableExperimentalFeatures: true
  routing:
    clusterHostSuffix: 192.168.49.2.nip.io
    defaultRoutingClass: basic
  workspace:
    defaultStorageSize:
      common: 20Gi
      perWorkspace: 29Gi
    imagePullPolicy: Always
    pvcName: new-custom-pvc-name
kind: DevWorkspaceOperatorConfig
metadata:
  name: new-external-config
  namespace: default
EOF


cat <<'EOF' | kubectl apply -n $NAMESPACE -f - 
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: new-dw-per-user-external
spec:
  started: true
  routingClass: 'basic'
  template:
    attributes:
      controller.devfile.io/devworkspace-config:
        name: new-external-config
        namespace: default
      controller.devfile.io/storage-type: common
    components:
      - name: web-terminal
        container:
          image: quay.io/wto/web-terminal-tooling:next
          memoryRequest: 256Mi
          memoryLimit: 512Mi
          mountSources: true
          command:
           - "tail"
           - "-f"
           - "/dev/null"
EOF

kubectl describe pvc -n $NAMESPACE | grep "Labels:" -A 3 -B 6

Observe a label "controller.devfile.io/devworkspace_pvc_type" added to certain kubernetes PVC objects:

claim-devworkspace PVC will not have this label, since this PVC was created with old DWO. Even new DWO
old-custom-pvc-name PVC will not have this label, but new-custom-pvc-name will have it
same for per-workspace, only the PVC for workspace started with new operator will have the type label

Now start deleting PVCs one after another with kubectl delete pvc
And see that workspaces are reconciled respectivelly.

PR Checklist

E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
- v8-devworkspace-operator-e2e: DevWorkspace e2e test
- v8-che-happy-path: Happy path for verification integration with Che

dkwon17 · 2024-02-14T20:35:06Z

I will review this PR

dkwon17 · 2024-02-16T18:44:02Z

controllers/workspace/eventhandlers.go

-					Name:      ownerref.Name,
-					Namespace: obj.GetNamespace(),
+	// No need to reconcile PVC, if it doesn't have a label specifying its type
+	pvcLabel, ok := obj.GetLabels()[constants.DevWorkspacePVCTypeLabel]


If a user upgrades from an older version of DWO to the latest version, will the older common PVCs get the new label?

@mkuznyetsov this is also my concern. There was an older PR that added labels per-workspace PVCs, but I'm almost certain this only impacted new per-workspace PVCs.

My concern stems from 2 things:

1. Making sure existing PVCs won't be deleted, then re-created to apply the label.

This would cause user data loss. Looking at the sync code, it seems like PVCs are not considered mutable, so the new label would not get applied to existing PVCs. There is however a note that we could still allow for updating labels.

If we want to update existing PVCs with the label, this complicates this PR further: either the sync code needs to be updated to only allow modifying PVCs if the labels are modified, or we need to manually diff the PVC after calling SyncObjectWithCluster(), see that the labels are missing and call sync.updateObjectGeneric() to apply the labels. The former approach is much more clean, though a bit trickier as SyncObjectWithCluster() is a critical function called throughout DWO.

2. If we decide to not update existing PVCs with the new label, then the dwPVCHandler() should still work on PVCs that are missing the new label.

This is currently not the case with the following check:

// No need to reconcile, if PVC doesn't have a label specifying its type pvcLabel, ok := obj.GetLabels()[constants.DevWorkspacePVCTypeLabel] if !ok { return []reconcile.Request{} }

You'd have to change the dwPVCHandler code to not assume that the constants.DevWorkspacePVCTypeLabel is applied to the PVC in question. If it does not exist, the behaviour should match the behaviour prior to this PR (i.e. the global common PVC name is assumed to be used, and the original PR bug will be present). If the label does exist, then you can make use of the logic that you've implemented.

In general, I think it's easier as a first step to have this PR not update existing PVCs with the new label (i.e. consider my 2nd concern). A later PR could update the sync code to allow label updating on PVCs.

alright, I will rewrite to account for the use of PVC with missing label, and leave a reference to this PR why this has to be this way

pr rewritten to support old usecase, when there is no new label

controllers/workspace/eventhandlers.go

dkwon17 · 2024-02-16T19:17:06Z

controllers/workspace/eventhandlers.go

+		for _, workspace := range dwList.Items {
+			// determin if PVC belongs to the workspace that has to be reconcile by its name
+			// which comes from the DW operator global, or external config that may be defined
+			// for this workspace


I suggest:

Determine workspaces to reconcile that use the current common PVC. Workspaces can either use the common PVC where the PVC name is coming from the global config, or from an external config the workspace might use

comment applied

dkwon17 · 2024-02-16T19:21:22Z

controllers/workspace/eventhandlers.go

+			// for this workspace
+			var workspacePvcName string;
+
+			if (workspace.Spec.Template.Attributes.Exists(constants.ExternalDevWorkspaceConfiguration)) {


Should we check if the workspace uses common/per-user storage by checking

storageType := workspace.Spec.Template.Attributes.GetString(constants.DevWorkspaceStorageTypeAttribute, nil)

first?

yes, thanks

AObuchow

@mkuznyetsov Thank you for the great first PR 🥳 Excited to have you contributing to the project. I've made a few initial remarks, but overall things are looking good :)

AObuchow · 2024-02-29T14:47:31Z

controllers/workspace/eventhandlers.go

+				externalConfig, _ := wkspConfig.ResolveConfigForWorkspace(&workspace, r.Client)
+				workspacePvcName = externalConfig.Workspace.PVCName
+			}
+			if len(workspacePvcName) == 0 {


We can avoid this if statement by immediately setting workspacePvcName to be the default global Config's PVC name. Then, the value of workspacePvcName will be modified if an external DWOC is used.

So line 84 could be:

workspacePVCName := wkspConfig.GetGlobalConfig().Workspace.PVCName

Also side note: the pattern we tend to use for checking empty strings is if myString == "" {...}. IMO this makes it a bit more clear that we're checking for an empty string.

AObuchow · 2024-02-29T14:55:21Z

controllers/workspace/eventhandlers.go

+			var workspacePvcName string;
+
+			if (workspace.Spec.Template.Attributes.Exists(constants.ExternalDevWorkspaceConfiguration)) {
+				externalConfig, _ := wkspConfig.ResolveConfigForWorkspace(&workspace, r.Client)


We can't ignore the error returned by ResolveConfigForWorkspace() since in error cases, it will return nil, error. Thus, trying to get the value of externalConfig.Workspace.PVCName will give a null pointer exception.

If there's an error that occurred, we should not modify the value of workspacePvcName. Ideally, we should log the error as well, though there isn't a logger set up in this file (and I'm not sure if you can log from an event handler yet?). I can look into this myself.

added logger

AObuchow · 2024-02-29T19:44:05Z

controllers/workspace/eventhandlers.go

-					Name:      ownerref.Name,
-					Namespace: obj.GetNamespace(),
+	// No need to reconcile PVC, if it doesn't have a label specifying its type
+	pvcLabel, ok := obj.GetLabels()[constants.DevWorkspacePVCTypeLabel]


@mkuznyetsov this is also my concern. There was an older PR that added labels per-workspace PVCs, but I'm almost certain this only impacted new per-workspace PVCs.

My concern stems from 2 things:

1. Making sure existing PVCs won't be deleted, then re-created to apply the label.

This would cause user data loss. Looking at the sync code, it seems like PVCs are not considered mutable, so the new label would not get applied to existing PVCs. There is however a note that we could still allow for updating labels.

If we want to update existing PVCs with the label, this complicates this PR further: either the sync code needs to be updated to only allow modifying PVCs if the labels are modified, or we need to manually diff the PVC after calling SyncObjectWithCluster(), see that the labels are missing and call sync.updateObjectGeneric() to apply the labels. The former approach is much more clean, though a bit trickier as SyncObjectWithCluster() is a critical function called throughout DWO.

2. If we decide to not update existing PVCs with the new label, then the dwPVCHandler() should still work on PVCs that are missing the new label.

This is currently not the case with the following check:

// No need to reconcile, if PVC doesn't have a label specifying its type pvcLabel, ok := obj.GetLabels()[constants.DevWorkspacePVCTypeLabel] if !ok { return []reconcile.Request{} }

You'd have to change the dwPVCHandler code to not assume that the constants.DevWorkspacePVCTypeLabel is applied to the PVC in question. If it does not exist, the behaviour should match the behaviour prior to this PR (i.e. the global common PVC name is assumed to be used, and the original PR bug will be present). If the label does exist, then you can make use of the logic that you've implemented.

In general, I think it's easier as a first step to have this PR not update existing PVCs with the new label (i.e. consider my 2nd concern). A later PR could update the sync code to allow label updating on PVCs.

AObuchow · 2024-02-29T19:47:38Z

pkg/constants/metadata.go

@@ -20,6 +20,9 @@ const (
 	// DevWorkspaceIDLabel is the label key to store workspace identifier
 	DevWorkspaceIDLabel = "controller.devfile.io/devworkspace_id"

+	// DevWorkspacePVCTypeLabel is the label key to identify DeWorkspace common PVCs and their type


This comment is slightly inaccurate, as we are using this label for both per-workspace and common/per-user PVC's.

I would rewrite it as:
// DevWorkspacePVCTypeLabel is the label key to identify PVCs used by DevWorkspaces and indicate their storage strategy.

thx, comment applied

AObuchow · 2024-03-22T17:20:37Z

@mkuznyetsov sorry about the failing CI tests, that's due to #1242 (not related to your PR). I've opened #1243 to resolve this.

AObuchow · 2024-04-09T19:16:52Z

controllers/workspace/eventhandlers.go

+	if obj.GetDeletionTimestamp() == nil {
+		return []reconcile.Request{}
+	}
+	// we can wrap the code below for handling per-workspace PVCs


Thanks for reporting #1250 -- I think this comment could be now simplified to something along the lines of:

// TODO: Ensure all new and existing PVC's get the `controller.devfile.io/devworkspace_pvc_type` label. // See: https://github.com/devfile/devworkspace-operator/issues/1250

AObuchow · 2024-04-09T19:18:15Z

pkg/constants/metadata.go

@@ -20,6 +20,9 @@ const (
 	// DevWorkspaceIDLabel is the label key to store workspace identifier
 	DevWorkspaceIDLabel = "controller.devfile.io/devworkspace_id"

+	// DevWorkspacePVCTypeLabel is the label key to identify PVCs used by DevWorkspaces and indicate their storage strategy.
+	DevWorkspacePVCTypeLabel = "controller.devfile.io/devworkspace_pvc_type_label"


I think the actual string value of this label could just be controller.devfile.io/devworkspace_pvc_type (i.e. remove the _label part at the end), since it's implied by its usage as a label in the PVC spec, and its name DevWorkspacePVCTypeLabel in the code.

controllers/workspace/eventhandlers.go

AObuchow · 2024-04-09T19:50:43Z

controllers/workspace/eventhandlers.go

+		if workspace.Spec.Template.Attributes.Exists(constants.ExternalDevWorkspaceConfiguration) {
+			externalConfig, err := wkspConfig.ResolveConfigForWorkspace(&workspace, r.Client)
+			if err != nil {
+				r.Log.Info("Couldn't fetch external config for workspace %s, using PVC Name from global config instead", err.Error())


We should test this logger works as expected by:

Creating an external DWOC that uses a custom PVC name

Using the external DWOC in a workspace that uses the common PVC storage strategy

Starting up the workspace that uses the external DWOC, wait for it to be in the READY state

Deleting the external DWOC

Deleting the common PVC

Ensure the log appears in DWO's logs

Example logger output, if devworkpace had it external config deleted, when attempting to reconcile
{"level":"info","ts":"2024-04-10T18:39:02+03:00","logger":"controllers.DevWorkspace","msg":"Couldn't resolve PVC name for workspace 'external-plain1' in namespace 'devworkspace-controller', using PVC name 'claim-devworkspace' from global config instead: could not fetch external DWOC with name ec1 in namespace default: DevWorkspaceOperatorConfig.controller.devfile.io \"ec1\" not found."}

AObuchow · 2024-04-09T20:25:57Z

@mkuznyetsov when you get a chance, please rebase your PR onto the main branch so that the Validate PR GH Action will pass btw :)

AObuchow · 2024-04-25T20:34:53Z

pkg/provision/storage/shared.go

+	if pvc.Labels == nil {
+		pvc.Labels = map[string]string{}
+	}
+	pvc.Labels[constants.DevWorkspacePVCTypeLabel] = constants.CommonStorageClassType


Could you change this to constants.PerUserStorageClassType please? Since "common" is the old/legacy name, and the user-facing name is "per-user"

AObuchow

@mkuznyetsov overall looks good to me :) Manual testing was complicated by #1258, but your PR seems good to me.

Let's wait until I get back from PTO on May 9th before merging this.

Amazing work & congrats on your first (soon to be finally merged!!) PR :D

AObuchow · 2024-05-10T14:46:02Z

@mkuznyetsov I think this PR is good to merge :) Before we do so, can you squash your commits with a git rebase --autosquash please? I also think a705e11 (#1233) could be squashed into 08e12bc (#1233).

Additionally, the commit description of 08e12bc (#1233) could maybe be re-worded to something like: feat: label PVCs by storage strategy

dkwon17 · 2024-05-10T15:30:46Z

controllers/workspace/eventhandlers.go

+				r.Log.Info(fmt.Sprintf("Couldn't resolve PVC name for workspace '%s' in namespace '%s', using PVC name '%s' from global config instead: %s.", workspace.Name, workspace.Namespace, workspacePVCName, err.Error()))
+			} else {
+				storageType := workspace.Spec.Template.Attributes.GetString(constants.DevWorkspaceStorageTypeAttribute, nil)
+				if storageType == constants.CommonStorageClassType || storageType == constants.PerUserStorageClassType {


Do we need to also check storageType == "" here?

@dkwon17 good catch!! Yes, we should be checking this too @mkuznyetsov

Also, should we be doing this check in the first line of this for loop instead?

Because AFAIK we are looking for common/per-user workspaces to reconcile in this for loop. Otherwise, it's possible to have ephemeral and per-workspace workspaces added in this for loop as well

+1 @dkwon17 you're right, the order of checking for workspace storage strategy before iterating over a workspace should have not changed. @mkuznyetsov please restore the 2 lines that were moved for checking the workspace storage strategy, so that they occur before we retrieve the PVC name.

AObuchow · 2024-05-10T18:57:56Z

pkg/provision/storage/shared.go

@@ -61,7 +61,6 @@ func WorkspaceNeedsStorage(workspace *dw.DevWorkspaceTemplateSpec) bool {
 }

 func getPVCSpec(name, namespace string, storageClass *string, size resource.Quantity) (*corev1.PersistentVolumeClaim, error) {
-


@mkuznyetsov sorry for nit-pick, but could you please also restore this newline so that the diff is a bit cleaner?

If possible, please re-add this newline.

AObuchow · 2024-05-15T15:31:57Z

pkg/provision/storage/shared.go

@@ -61,7 +61,7 @@ func WorkspaceNeedsStorage(workspace *dw.DevWorkspaceTemplateSpec) bool {
 }

 func getPVCSpec(name, namespace string, storageClass *string, size resource.Quantity) (*corev1.PersistentVolumeClaim, error) {
-
+	


If possible, please remove this tab (unless it's coming from go format)

oops, fixed it in the amended commit

AObuchow

Please run make format with goimports installed go install golang.org/x/tools/cmd/goimports@latest

Signed-off-by: Mykhailo Kuznietsov <[email protected]>

AObuchow

LGTM :)

openshift-ci · 2024-05-16T18:01:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, mkuznyetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [AObuchow]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AObuchow · 2024-05-16T18:02:25Z

Congrats on having your first PR merged to the project @mkuznyetsov 🎉 Amazing work :)

mkuznyetsov requested review from AObuchow, dkwon17 and ibuziuk as code owners February 14, 2024 08:03

dkwon17 reviewed Feb 16, 2024

View reviewed changes

controllers/workspace/eventhandlers.go Outdated Show resolved Hide resolved

dkwon17 reviewed Feb 16, 2024

View reviewed changes

AObuchow requested changes Feb 29, 2024

View reviewed changes

openshift-ci bot assigned AObuchow Feb 29, 2024

mkuznyetsov force-pushed the dwo-920 branch from a13981d to 3b3c2f6 Compare March 27, 2024 14:58

AObuchow reviewed Apr 9, 2024

View reviewed changes

controllers/workspace/eventhandlers.go Show resolved Hide resolved

AObuchow reviewed Apr 9, 2024

View reviewed changes

controllers/workspace/eventhandlers.go Show resolved Hide resolved

AObuchow reviewed Apr 9, 2024

View reviewed changes

mkuznyetsov force-pushed the dwo-920 branch from 3b3c2f6 to 37212ba Compare April 10, 2024 16:01

mkuznyetsov force-pushed the dwo-920 branch from 37212ba to e98589c Compare April 25, 2024 17:43

AObuchow reviewed Apr 25, 2024

View reviewed changes

AObuchow mentioned this pull request Apr 26, 2024

Deleted common/per-user PVC causes workspaces to be stuck until timeout #1258

Open

AObuchow approved these changes Apr 26, 2024

View reviewed changes

openshift-ci bot added lgtm approved labels Apr 26, 2024

dkwon17 reviewed May 10, 2024

View reviewed changes

AObuchow reviewed May 10, 2024

View reviewed changes

mkuznyetsov force-pushed the dwo-920 branch from f832f37 to be8b2d5 Compare May 15, 2024 15:06

openshift-ci bot removed the lgtm label May 15, 2024

AObuchow reviewed May 15, 2024

View reviewed changes

feat: Use labels on PVCs for better reconciling

08f9082

Signed-off-by: Mykhailo Kuznietsov <[email protected]>

mkuznyetsov force-pushed the dwo-920 branch from be8b2d5 to 08f9082 Compare May 16, 2024 14:39

AObuchow approved these changes May 16, 2024

View reviewed changes

openshift-ci bot added the lgtm label May 16, 2024

AObuchow merged commit 715d43f into main May 16, 2024
8 checks passed

AObuchow deleted the dwo-920 branch May 16, 2024 18:01

AObuchow mentioned this pull request May 16, 2024

Annotate DWO-created PVC's #920

Closed

		@@ -61,7 +61,6 @@ func WorkspaceNeedsStorage(workspace *dw.DevWorkspaceTemplateSpec) bool {
		}

		func getPVCSpec(name, namespace string, storageClass string, size resource.Quantity) (corev1.PersistentVolumeClaim, error) {

		@@ -61,7 +61,7 @@ func WorkspaceNeedsStorage(workspace *dw.DevWorkspaceTemplateSpec) bool {
		}

		func getPVCSpec(name, namespace string, storageClass string, size resource.Quantity) (corev1.PersistentVolumeClaim, error) {

feat: Use labels on PVCs for better reconciling #1233

feat: Use labels on PVCs for better reconciling #1233

Conversation

mkuznyetsov commented Feb 14, 2024 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

PR Checklist

dkwon17 commented Feb 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1. Making sure existing PVCs won't be deleted, then re-created to apply the label.

2. If we decide to not update existing PVCs with the new label, then the dwPVCHandler() should still work on PVCs that are missing the new label.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AObuchow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1. Making sure existing PVCs won't be deleted, then re-created to apply the label.

2. If we decide to not update existing PVCs with the new label, then the dwPVCHandler() should still work on PVCs that are missing the new label.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AObuchow commented Mar 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AObuchow commented Apr 9, 2024

Choose a reason for hiding this comment

AObuchow left a comment

Choose a reason for hiding this comment

AObuchow commented May 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dkwon17 May 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AObuchow left a comment

Choose a reason for hiding this comment

AObuchow left a comment

Choose a reason for hiding this comment

openshift-ci bot commented May 16, 2024

AObuchow commented May 16, 2024

mkuznyetsov commented Feb 14, 2024 •

edited

Loading

2. If we decide to not update existing PVCs with the new label, then the `dwPVCHandler()` should still work on PVCs that are missing the new label.

2. If we decide to not update existing PVCs with the new label, then the `dwPVCHandler()` should still work on PVCs that are missing the new label.

dkwon17 May 10, 2024 •

edited

Loading