Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ubi8 workflows, add job to build udi9 #192

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Nov 20, 2024

Part of eclipse-che/che#23034

This PR

  • updates the README
  • updates the contributing guide
  • removes the ubi8 and udi8 build jobs
  • adds the udi9 build job

Currently we have:

https://quay.io/repository/devfile/base-developer-image:ubi9-latest

https://quay.io/repository/devfile/base-developer-image:ubi8-latest     ------
                                                                              |-- same image
https://quay.io/repository/devfile/base-developer-image:latest     -----------

After this PR, the ubi9-latest and latest tags will refer to the same image for both base-developer-image and universal-developer-image:

https://quay.io/repository/devfile/base-developer-image:ubi8-latest

https://quay.io/repository/devfile/base-developer-image:ubi9-latest     ------
                                                                              |-- same image
https://quay.io/repository/devfile/base-developer-image:latest     -----------

.github/workflows/ubi9-build.yaml Outdated Show resolved Hide resolved
.github/workflows/ubi9-build.yaml Outdated Show resolved Hide resolved
Signed-off-by: David Kwon <[email protected]>
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svor
Copy link
Collaborator

svor commented Nov 21, 2024

We might need a follow-up issue to update the image specified in the devfile.yaml for several repositories, such as:

Copy link
Contributor

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

Copy link

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, ibuziuk, svor, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit 9aeabfa into devfile:main Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants