chore: define user directory for binaries #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
svor
approved these changes
Sep 5, 2023
l0rd
approved these changes
Sep 5, 2023
AObuchow
approved these changes
Sep 5, 2023
|
@AObuchow: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AObuchow, l0rd, svor, vitaliy-guliy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AObuchow
reviewed
Sep 5, 2023
Signed-off-by: Vitaliy Gulyy <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/home/user/.local/bindirectory may contain binaries, that could be inaccessible when using VS Code tasks.For instance, this directory contains a link to
podman. If I launch VS Code task, environment variables appear to be not properly/completely initialized and/home/user/.local/binis not added toPATH.One of the solutions is to create a directory for binaries and add it to the
PATHvariable in the Dockerfile directly.Required for eclipse-che/che#22292