New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync `install.sh` to `devcontainer-feature.json` default values #867

Merged

samruddhikhandale merged 3 commits into devcontainers:main from lucasfcnunes:main

Feb 23, 2024

Contributor

lucasfcnunes commented Feb 16, 2024 •

edited

Loading

Description

Syncs SOME install.sh env vars to their respective devcontainer-feature.json default values
DooD line 187: err: command not found #865 is caused by a missing a version on the MOBYBUILDXVERSION env var.

Execution

Regex find ^[A-Z0-9_]+="\$\{[^:]+?\} on install.sh files
Bump patch versions on respective devcontainer-feature.json files

Related

Fixes DooD line 187: err: command not found #865

lucasfcnunes requested a review from a team as a code owner

February 16, 2024 16:34

lucasfcnunes force-pushed the main branch from bb20451 to e0399dd Compare

February 16, 2024 16:41

Contributor Author

lucasfcnunes commented Feb 16, 2024

@microsoft-github-policy-service agree

samruddhikhandale reviewed

View reviewed changes

src/docker-in-docker/install.sh Outdated Show resolved Hide resolved

src/docker-in-docker/install.sh Outdated Show resolved Hide resolved

samruddhikhandale mentioned this pull request

DooD line 187: err: command not found #865

Closed

samruddhikhandale requested changes

View reviewed changes

src/docker-in-docker/install.sh Outdated Show resolved Hide resolved

src/docker-in-docker/install.sh Show resolved Hide resolved

samruddhikhandale requested changes

View reviewed changes

src/docker-in-docker/install.sh Outdated Show resolved Hide resolved

lucasfcnunes changed the title ~~add default value to MOBYBUILDXVERSION~~ sync install.sh to devcontainer-feature.json default values

lucasfcnunes added 3 commits

February 22, 2024 22:35


          add default value to MOBYBUILDXVERSION

Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>


          bump updated features patch versions

dc1c321

Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>


          sync missing default values to install.sh

8829f3f

find `^[A-Z0-9_]+="\$\{[^:]+?\}`
on `install.sh` files

Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>

lucasfcnunes force-pushed the main branch from 55f0718 to 8829f3f Compare

February 23, 2024 01:46

samruddhikhandale approved these changes

View reviewed changes

samruddhikhandale merged commit 758b032 into devcontainers:main

138 of 139 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet