Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-in-docker] : Bug fix - Buildx installation when moby:false #827

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[docker-in-docker] : Bug fix - Buildx installation when moby:false #827

merged 1 commit into from
Jan 31, 2024

Conversation

samruddhikhandale
Copy link
Member

Closes #817

Syncs buildx installation directory when moby:true and moby:false which also avoids the problem mentioned in #817 (comment)

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner January 31, 2024 19:13
joshspicer
joshspicer approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@samruddhikhandale samruddhikhandale merged commit 6d6fb2b into main Jan 31, 2024
111 checks passed
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/dnd-buildx branch January 31, 2024 20:04
@stefan-cukl stefan-cukl mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docker-in-docker] Docker buildx not installed in Codespaces
2 participants
@samruddhikhandale @joshspicer