-
Notifications
You must be signed in to change notification settings - Fork 444
Add new option to install azure-cli extensions #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f1f3800
to
af0f396
Compare
With devcontainers/spec/issues/91 closed and env variable for user tested on vscode-remote-release/issues/7404, code has been updated to use the new env variable This relies on Dev Containers extension v0.261.0 or higher and this will be ready merge once the latest extension goes into general release. |
@jkeech, would you be able to review this and let me know if I am missing anything? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you taken a stab at writing a scenario test for this change? I think it would be really useful.
We have some documentation on the concept here, as well as plenty of examples in this repo (one such example)
@pauldotyu - Also I am excited to share that with the newest build to the devcontainer CLI, we are injecting variables into Feature We have some docs here - I think it will be really useful for what you're trying to accomplish with the |
Thanks for pointing me to this. I've just added test scenario for some specific azure cli extensions |
Yes, I noticed the change was made to include the This PR should be ready for another review. Just let me know if I am missing anything else. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, the Codespaces side of the team has been a busy few weeks leading up to GitHub Universe :)
Thanks for the contribution - this looks great :)
@jkeech and @asaikali - I have the code working which would resolve #149 but my solution for obtaining the
remoteUser
is a bit of a hack (for now). Will keep this as a draft PR until devcontainers/spec#91 is sorted out.