-
Notifications
You must be signed in to change notification settings - Fork 458
[node] - Node 18 EOL changes #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlvaroRausell
merged 9 commits into
devcontainers:main
from
Kaniska244:node_18_EOL_changes
Jun 11, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
324b928
Node 18 EOL changes
Kaniska244 9ae64f3
Fixing failing tests
Kaniska244 a2770b2
Merge branch 'main' into node_18_EOL_changes
Kaniska244 000fd32
Updating based on review comments
Kaniska244 7b27672
Merge branch 'main' into node_18_EOL_changes
Kaniska244 db4392f
Merge branch 'main' into node_18_EOL_changes
AlvaroRausell 54be27d
Merge branch 'main' into node_18_EOL_changes
Kaniska244 ee53857
Merge branch 'main' into node_18_EOL_changes
AlvaroRausell 73a5d8a
Merge branch 'main' into node_18_EOL_changes
AlvaroRausell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#!/bin/bash | ||
|
||
set -e | ||
|
||
# Optional: Import test library | ||
source dev-container-features-test-lib | ||
|
||
# Definition specific tests | ||
check "version" bash -c "node --version | grep 22" | ||
check "pnpm" bash -c "pnpm -v | grep 8.8.0" | ||
check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10" | ||
|
||
# Report result | ||
reportResults | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.