Skip to content

[node] - Node 18 EOL changes #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/node/devcontainer-feature.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "node",
"version": "1.6.2",
"version": "1.6.3",
"name": "Node.js (via nvm), yarn and pnpm",
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/node",
"description": "Installs Node.js, nvm, yarn, pnpm, and needed dependencies.",
Expand All @@ -11,9 +11,8 @@
"lts",
"latest",
"none",
"18",
"16",
"14"
"22",
"20"
],
"default": "lts",
"description": "Select or enter a Node.js version to install"
Expand Down
9 changes: 4 additions & 5 deletions test/node/install_additional_node.sh
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@ set -e
# Optional: Import test library
source dev-container-features-test-lib

# 'lts' is now some version of node 20...
check "version_on_path" node -v | grep 20
# 'lts' is now some version of node 22...
check "version_on_path" node -v | grep 22
check "pnpm" bash -c "pnpm -v | grep 8.8.0"

check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20
check "v14_installed" ls -1 /usr/local/share/nvm/versions/node | grep 14.19.3
check "v17_installed" ls -1 /usr/local/share/nvm/versions/node | grep 17.9.1
check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20.19.1
check "v19_installed" ls -1 /usr/local/share/nvm/versions/node | grep 19.9.0


# Report result
Expand Down
8 changes: 4 additions & 4 deletions test/node/install_additional_node_on_rhel_family.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ set -e
# Optional: Import test library
source dev-container-features-test-lib

# 'lts' is now some version of node 20...
check "version_on_path" node -v | grep 20
# 'lts' is now some version of node 22...
check "version_on_path" node -v | grep 22
check "pnpm" bash -c "pnpm -v | grep 6.16.0"

check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20
check "v14_installed" ls -1 /usr/local/share/nvm/versions/node | grep 14.19.3
check "v17_installed" ls -1 /usr/local/share/nvm/versions/node | grep 17.9.1
check "v19_installed" ls -1 /usr/local/share/nvm/versions/node | grep 19.9.0
check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20.19.1


# Report result
Expand Down
15 changes: 15 additions & 0 deletions test/node/install_node_22_on_jammy.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/bin/bash

set -e

# Optional: Import test library
source dev-container-features-test-lib

# Definition specific tests
check "version" bash -c "node --version | grep 22"
check "pnpm" bash -c "pnpm -v | grep 8.8.0"
check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10"

# Report result
reportResults

14 changes: 7 additions & 7 deletions test/node/scenarios.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
"version": "lts"
}
}
},
},
"install_additional_node": {
"image": "debian:11",
"features": {
"node": {
"version": "lts",
"additionalVersions": "v17.9.1,v14.19.3",
"additionalVersions": "v20.19.1,v19.9.0",
"pnpmVersion": "8.8.0"
}
}
Expand All @@ -22,7 +22,7 @@
"features": {
"node": {
"version": "lts",
"additionalVersions": "v17.9.1,v14.19.3",
"additionalVersions": "v20.19.1,v19.9.0",
"pnpmVersion": "6.16.0"
}
}
Expand Down Expand Up @@ -77,11 +77,11 @@
}
}
},
"install_node_16_on_bionic": {
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-18.04",
"install_node_22_on_jammy": {
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-22.04",
"features": {
"node": {
"version": "16",
"version": "22",
"pnpmVersion":"8.8.0"
}
}
Expand Down Expand Up @@ -200,4 +200,4 @@
}
}
}
}
}