Skip to content

Create LLVM feature #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Create LLVM feature #16

wants to merge 8 commits into from

Conversation

jcbhmr
Copy link
Member

@jcbhmr jcbhmr commented May 1, 2023

⚠️ based on #15's branch!

This is a feature that I've had in my own feature repository under @jcbhmr for a while, and I think it's a reasonably widespread tool and might be worth adopting into this @devcontainers-community organization? If we aren't ready to actually do features yet @eitsupi I can continue housing this under my @jcbhmr feature repo.

This PR would...

  • Create a VERY basic LLVM feature
  • Use the official installer
  • Have comments in the code to attempt to explain what's happening and why. Shell scripts can get complicated!

@jcbhmr jcbhmr added the enhancement New feature or request label May 1, 2023
@jcbhmr jcbhmr self-assigned this May 1, 2023
@eitsupi
Copy link
Contributor

eitsupi commented May 1, 2023

I think anything should not be added at this point as there are no acceptance criteria for this repository.

For example, there are clear criteria in linguist that control the language that GitHub recognizes. We need to determine such criteria.
https://github.com/github-linguist/linguist/blob/master/CONTRIBUTING.md#adding-an-extension-to-a-language

@jcbhmr
Copy link
Member Author

jcbhmr commented May 1, 2023

@eitsupi Good idea! Will do. 🚀

@jcbhmr jcbhmr mentioned this pull request May 1, 2023
@jcbhmr jcbhmr added this to the First feature milestone May 1, 2023
@jcbhmr jcbhmr mentioned this pull request May 2, 2023
6 tasks
@jcbhmr jcbhmr closed this May 2, 2023
@eitsupi eitsupi deleted the add-llvm branch May 2, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants