Open
Conversation
Deepanshu-Rohilla
approved these changes
Nov 13, 2020
Member
Deepanshu-Rohilla
left a comment
Deepanshu-Rohilla
left a comment
There was a problem hiding this comment.
I think it is fine now.
tmibvishal
requested changes
Nov 13, 2020
Member
There was a problem hiding this comment.
print(e.toString()) is okay if you just want to debug the code. But when adding scaffold, you should add a custom string about what error means. Or if you want to keep things simple, you can do something like this.
String errStr = error.message == null ? error.toString() : error.message;
Then show errStr in snackbar
| Scaffold.of(context).showSnackBar(SnackBar( | ||
| backgroundColor: Theme.of(context).primaryColor, | ||
| content: Text( | ||
| e.toString(), |
Member
There was a problem hiding this comment.
Use e.message here or custom string according to error. e.toString() gives were a complicated string of error object hard to understand for a normal user.
| @@ -121,6 +128,15 @@ class _VerificationCheckState extends State<VerificationCheck> { | |||
| setState(() { | |||
| error = e.toString(); | |||
Member
There was a problem hiding this comment.
Show e.message as message or custom string according to error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I set the hard wrap to 900, and I have compared the code there are only additions no deletions. Hence, I guess now the code is formatted as per the guidelines.