-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for PostgreSQL #725
base: master
Are you sure you want to change the base?
Conversation
Wow, that's awesome! Thank you! If you have any problems or questions, feel free to reach out! |
224aeae
to
fcfe9c6
Compare
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
…lint Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
Signed-off-by: Mahdi Fooladgar (professormahi) <[email protected]>
I think the base version is ready for review after merging dev-sec/postgres-baseline#54. |
This PR is ready to review after the workflow approval. @rndmh3ro |
Thanks @professormahi, sounds awesome. I'll try to take a look next week! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took an initial look and have some remarks, but great work nonetheless!
################################# | ||
# POSTGRES-02 ################### | ||
################################# | ||
- name: Get postgres version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the postgresql_info_module here? According to the docs, getting the version is supported by the module.
Or don't you want to do this because then we'd have to connect to the postgres?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@professormahi What do you think about this?
# POSTGRES-07/11/12/16 ########## | ||
################################# | ||
- name: Secure postgresql.conf Configuration | ||
ansible.builtin.lineinfile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of using lineinfile
. I'd rather use template
.
Now I guess templating the whole postgresql.conf
-file would be inconvenient, can we use includes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@professormahi What do you think about this?
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
I'm working on adding PostgreSQL hardening role to this collection.