Repository navigation
fix: split preview profile literal so CI can type-check it - #5
Merged
nunomaduro merged 1 commit intoOct 29, 2026
Merged
Conversation
Contributor
Author
|
Ran the workflow on my fork while this one waits for approval. It's green on the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests have been failing on
productionsince "fix: keystrokes". The build stops before any test runs:The profile route in the preview store returned one big
[String: Any]literal with a closure inside it. The Swift on the CI runner gives up on it. Newer Swift builds it fine, which is why it passes locally.This splits the literal into typed
lets (buckets,badges,activity,achievements,body). Same data, same keys. The code is DEBUG-only preview code.swift testpasses locally. A green run here confirms the fix.