feat: add TOTP-based 2FA support for V2 authentication#35
Open
mark-tt wants to merge 2 commits intodev-mirzabicer:mainfrom
Open
feat: add TOTP-based 2FA support for V2 authentication#35mark-tt wants to merge 2 commits intodev-mirzabicer:mainfrom
mark-tt wants to merge 2 commits intodev-mirzabicer:mainfrom
Conversation
The SDK already had authenticate_2fa() implemented but the initialization flow didn't use it - when 2FA was required, it would catch the error and give up. This change completes the 2FA flow automatically using a TOTP secret provided via the TICKTICK_TOTP_SECRET environment variable. Uses only stdlib modules (hmac, hashlib, struct) to generate TOTP codes per RFC 6238, so no new dependencies are needed. Closes dev-mirzabicer#27
The TickTick API sometimes returns "" (empty string) for the repeatFrom field instead of an integer or null. Add a field_validator to coerce empty strings to None, preventing Pydantic validation errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK already had authenticate_2fa() implemented but the initialization flow didn't use it - when 2FA was required, it would catch the error and give up. This change completes the 2FA flow automatically using a TOTP secret provided via the TICKTICK_TOTP_SECRET environment variable.
Uses only stdlib modules (hmac, hashlib, struct) to generate TOTP codes per RFC 6238, so no new dependencies are needed.
Closes #27