fix: handle string and empty repeatFrom values from API#29
Open
crisperit wants to merge 1 commit intodev-mirzabicer:mainfrom
Open
fix: handle string and empty repeatFrom values from API#29crisperit wants to merge 1 commit intodev-mirzabicer:mainfrom
crisperit wants to merge 1 commit intodev-mirzabicer:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The TickTick API returns repeatFrom as a string ("0", "1", "2"),
null, or empty string, but the model expected int | None.
Added field validator to parse all cases correctly.
Fixes dev-mirzabicer#7
crisperit
force-pushed
the
fix/7-repeat-from-string-parsing
branch
from
e9d19e5 to
ae857d5
Compare
|
Any plans to accep this PR? having the same issue as well over here |
hardane
pushed a commit
to hardane/ticktick-sdk
that referenced
this pull request
Mar 16, 2026
- auth.py & client.py: Mimic real browser headers (Chrome UA, Origin, Referer, full x-device) to avoid TickTick's AWS ELB rate limiting. Ref: dev-mirzabicer#34 - task.py: Add field_validator for repeat_from to handle string/empty values from TickTick API (e.g. "0", "1", ""). Ref: dev-mirzabicer#29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repeatFromfield correctly"0","1","2"),null, and empty string""repeatFromas a string, but the model expectedint | NoneFixes #7
Test plan
ticktick_list_tasks- tasks with recurring schedules now parse correctly