Implmeneted the delivery stop#610
Conversation
|
@Nanafancy is attempting to deploy a commit to the determined's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Nanafancy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
determined-001
left a comment
determined-001
left a comment
There was a problem hiding this comment.
The PR includes a package-lock.json at the root — this project uses pnpm as its package manager, so package-lock.json is not the correct lockfile and should not be committed. Please remove it and resubmit. Also note that WebhookDelivery.stop() for issue #374 has already landed on main; please verify your change adds something beyond what's there.
…termined-001#374) Rewritten against current main since PR determined-001#610's committed diff did not parse (dangling type literal, duplicated verifyWebhookRaw bodies) and its branch predated the RetryQueue/concurrent-delivery-cap refactors.
determined-001
force-pushed
the
Delivery-Stop
branch
from
ae06a01 to
475c61c
Compare
3 participants
Linked issue
Closes #374
2.37 — WebhookDelivery.stop()
Complexity: Trivial — 100 Points · type:feature
Milestone: v1.0 hardening
Context
A WebhookDelivery stops when its watcher stops. No independent shutdown path.
Problem
Tests that need to halt a delivery without stopping the watcher have no clean API.
What needs to be done
Add idempotent WebhookDelivery.stop() that clears retry timers and removes the listener.
Key files
packages/pulse-webhooks/src/index.ts.
Done when
After stop(), no further deliveries are attempted.