Fix issue where promise-style requests throw an error if no params are passed #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only checks here that are failing are based on another dependency using Will someone please consider merging this sooner than later? Also are the failing versions of NPM in the CI Build actually supported? Can they be removed? |
|
Hey @ryangiglio if you're still interested in a promise implementation, we rewrote node-twitter from the ground up here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With callback-style requests, the
paramsargument is always present whether it's actually a params object or a function. But with promise-style requests, it's possible to make a call without theparamsargument at all, so we need to check that it's defined before trying to use it.