Restore menu item focus for accessibility, fix DropdownMenu#293
Merged
john-preston merged 1 commit intodesktop-app:masterfrom Mar 12, 2026
Merged
Conversation
Re-enable setFocus() in menu item selection for screen reader support. Save and restore the previously focused widget in DropdownMenu so that focus returns correctly when the menu hides.
rezabakhshilaktasaraei
force-pushed
the
fix/dropdown-menu-focus-restore
branch
from
66c8d33 to
99aaa5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setFocus()inItemBase::setSelected()for screen reader support (reverted in 6d3541f)Problem
Setting focus on menu items is needed for screen readers (NVDA/JAWS) to announce selected items. However, this broke DropdownMenu (in-window menus like the attach menu): focus was grabbed from the input field, and when the menu closed, focus jumped to the first focusable widget (chats search) instead of returning to the original widget.
Solution
Save/restore focus in
DropdownMenu:QApplication::focusWidget()(only if not already a child of the menu)This keeps accessibility working (menu items get focus for screen readers) while ensuring DropdownMenu doesn't permanently steal focus.