REQUIRE_JEMALLOC and USE_RNNOISE switches#112
Open
mymedia2 wants to merge 2 commits intodesktop-app:masterfrom
Open
REQUIRE_JEMALLOC and USE_RNNOISE switches#112mymedia2 wants to merge 2 commits intodesktop-app:masterfrom
mymedia2 wants to merge 2 commits intodesktop-app:masterfrom
Conversation
This was referenced Jul 29, 2021
Contributor
|
cmake_helpers has variables like DESKTOP_APP_DISABLE_*, not REQUIRE or USE |
Do not require jemalloc at runtime, allow one to use system memory allocator.
RNNoise comes with an ML model trained using closed data. That's unacceptable in most Linux distributions due to legal issues. See discussion on Debian bug tracker: https://bugs.debian.org/980839#17
Contributor
Author
|
@ilya-fedin The USE_RNNOISE switch follows the same named macro in the tgcalls subproject. |
Contributor
|
See #183. |
|
john-preston
force-pushed
the
master
branch
from
e909a3a to
491a7fd
Compare
yasid-ai
approved these changes
Jan 25, 2025
yasid-ai
approved these changes
Feb 5, 2025
Originalmenace
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: TelegramMessenger/tgcalls#10