Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added option to dismiss screen error on input #1045

Merged
merged 2 commits into from
Mar 10, 2025
Merged

feat: added option to dismiss screen error on input #1045

merged 2 commits into from
Mar 10, 2025

Conversation

nirgur
Copy link
Collaborator

@nirgur nirgur commented Mar 9, 2025

@vercel Vercel
Copy link

vercel bot commented Mar 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 9:15am
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 9:15am
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 9:15am
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 9:15am
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 9:15am

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 34e8857.

Command Status Duration Result
nx affected --target test:e2e ✅ Succeeded 1m 13s View ↗
nx affected --target test ✅ Succeeded 1m 30s View ↗
nx affected --target lint --fix=true ✅ Succeeded 17s View ↗
nx affected --target build ✅ Succeeded 1m 12s View ↗
nx affected --target licenseCheck ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-10 09:15:43 UTC

@nirgur nirgur changed the title added option to dismiss screen error on input feat: added option to dismiss screen error on input Mar 9, 2025
asafshen
asafshen reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@asafshen asafshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, few questions

@nirgur nirgur merged commit 4d9e58d into main Mar 10, 2025
10 checks passed
@nirgur nirgur deleted the issue8643 branch March 10, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafshen asafshen asafshen approved these changes

@tomerlichtash tomerlichtash Awaiting requested review from tomerlichtash

@nmacianx nmacianx Awaiting requested review from nmacianx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirgur @asafshen