-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to set a custom verbose name #770
base: master
Are you sure you want to change the base?
Conversation
Let's continue discussion here.
From my point of view, Maybe it's better to use approach with adding new setting? What benefits of current approach with (That's not a request to rewrite, just a discussion. You're building this feature for yourself and it's fine either way) |
Sure, My understanding is that The goal is to customize the I like a solution that keeps all code for translating models in the The approach of using TranslationOptions is also nice because you could have different name formatting for different models. |
Only if you plan to use it. If not, we can leave default here.
Do you really need this? From my point of view, it would be simpler to just change setting, and have all models use new format. Also, variant with a setting takes care of |
No, I doubt there is much of a practical need for it. I see what you are saying with |
Great, let's remove that last obsolete test and we can merge this. |
Adds the option to override the verbose name created by DjangoModelTranslation to the TranslationOptions.
This allows for creating a custom verbose name to be displayed in the Django Admin.
Note
I tried to run linters on the project and it resulted in a huge set of changes so I left them out of this PR.
Closes #768