Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): Use ForeignObjectRel.hidden field from django 5.1 #756

Merged
merged 8 commits into from
Nov 11, 2024

Conversation

last-partizan
Copy link
Collaborator

Refs #719

@Freakness109
Copy link

If you don't mind me adding the results of some investigations:
The main issue seems to be that accessor_name on ForeignObjectRel got turned into a cached property (django/django@5e80390, upstream https://code.djangoproject.com/ticket/35230). That means that as soon as related_name is overwritten in e.g. fields.py, the accessor_name will have an out-of-date string. Not sure how to fix it short of updating accessor_name manually.

@last-partizan
Copy link
Collaborator Author

@Freakness109 your investigations was very useful!

Please, take a look at this PR, and test it with your project.

@last-partizan last-partizan self-assigned this Nov 9, 2024
@last-partizan last-partizan merged commit 7a60ca1 into master Nov 11, 2024
31 checks passed
@last-partizan last-partizan deleted the django-5.1 branch November 11, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants