Skip to content

fix: prevent infinite loop that happens when there is only 1 peer #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarkerK wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prevent infinite loop that happens when there is only 1 peer #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
565927e
fix: prevent infinite loop that happens when there is only 1 peer
HarkerK Jul 13, 2022
5a81ec2
maybe this is better
HarkerK Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions p2p/connection_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ func broadcast_Block_Coded(cbl *block.Complete_Block, PeerID uint64, first_seen
globals.Logger.Error(nil, "we want to broadcast block, but donot have peers, most possibly block will go stale")
return
}
if len(connections) == 1 && (PeerID == connections[0].Peer_ID || connections[0].Peer_ID == GetPeerID()) {
return
}
for _, v := range connections {
select {
case <-Exit_Event:
Expand Down