fix(deriv_auth): Refactor isSvgAccount
check using landing_company API
#986
+90
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup link:
https://app.clickup.com/t/20696747/GRWT-6679
https://app.clickup.com/t/20696747/GRWT-6683
This PR contains the following changes:
This PR updates the isSvgAccount method to improve accuracy in detecting whether an account is associated with SVG (St. Vincent & the Grenadines) by removing reliance on upgradeableLandingCompanies, which is no longer a reliable source for wallet accounts. And, setting the default account type in NewVirtualAccountRequestModel to 'dynamic' to support the wallet signup use case.
Developers Note (Optional)
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
@ahrar-deriv
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)