Skip to content

Aswathy/fix: codeQL workflows #18601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aswathy-deriv
Copy link
Contributor

@aswathy-deriv aswathy-deriv commented Jun 18, 2025

Changes:

This pull request updates the GitHub Actions workflows to explicitly set permissions for the contents scope to read. This change enhances security by adhering to the principle of least privilege, ensuring that workflows only have the permissions they need.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 18, 2025 10:25am

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/18601](https://github.com/deriv-com/deriv-app/pull/18601)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aswathy-deriv-fix-codeql-workflows.binary.sx?qa_server=red.derivws.com&app_id=32868
    - **Original**: https://deriv-app-git-fork-aswathy-deriv-fix-codeql-workflows.binary.sx
- **App ID**: `32868`

Copy link
Contributor

Generating Lighthouse report...

Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@habib-deriv habib-deriv self-requested a review June 18, 2025 10:37

permissions:
contents: write

on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aswathy-deriv let's try with test.yml, if we need write, or read is enough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we put the permisison on job level, like @rupato-deriv's PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But @habib-deriv ,actually its written that each workflow file to define the minimum required permissions: block at the top level (before jobs:)
Screenshot 2025-06-18 at 2 58 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants