-
Notifications
You must be signed in to change notification settings - Fork 351
Aswathy/fix: codeQL workflows #18601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
⏳ Generating Lighthouse report... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
permissions: | ||
contents: write | ||
|
||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aswathy-deriv let's try with test.yml, if we need write, or read is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can we put the permisison on job level, like @rupato-deriv's PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But @habib-deriv ,actually its written that each workflow file to define the minimum required permissions: block at the top level (before jobs:)
Changes:
This pull request updates the GitHub Actions workflows to explicitly set permissions for the contents scope to read. This change enhances security by adhering to the principle of least privilege, ensuring that workflows only have the permissions they need.
Screenshots:
Please provide some screenshots of the change.