Skip to content

fix: change validation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: change validation #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
352ce3a
fix: change validation
mayuran-deriv May 7, 2025
dec994a
fix: remove console
mayuran-deriv May 7, 2025
17de631
fix: added validation text
mayuran-deriv May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/features/dashboard/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ const base_schema = {
message: 'Your website URL cannot exceed 255 characters.',
}),
)
.notRequired()
.required(
translate({
message: 'Redirect URL is required to enable OAuth on your app.',
}),
)
.matches(urlRegex, {
message: translate({
message: 'Enter a valid URL. (Example: https://www.[YourDomainName].com)',
Expand Down
8 changes: 4 additions & 4 deletions src/features/dashboard/update-app/AppUpdateForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ const AppUpdateForm = ({ initialValues, submit, onCancel, is_loading }: TAppForm
setIsAdminPopupVisible(false);
setValue('admin', true, { shouldValidate: true, shouldDirty: true });
};

return (
<div className='update_form'>
<FormProvider {...methods}>
Expand All @@ -91,7 +90,7 @@ const AppUpdateForm = ({ initialValues, submit, onCancel, is_loading }: TAppForm
<TextField
{...register('name')}
label={translate({ message: 'App’s name' })}
placeholder={translate({ message: 'App’s name' })}
placeholder={translate({ message: '*App’s name (Required)' })}
inputSize='md'
variant='outline'
value={initialValues?.name}
Expand All @@ -113,7 +112,8 @@ const AppUpdateForm = ({ initialValues, submit, onCancel, is_loading }: TAppForm
</Translate>{' '}
<UnderlinedLink
text={translate({ message: 'documentation' })}
linkTo="https://developers.deriv.com" />
linkTo='https://developers.deriv.com'
/>
.
</Text>
<SectionMessage
Expand Down Expand Up @@ -196,7 +196,7 @@ const AppUpdateForm = ({ initialValues, submit, onCancel, is_loading }: TAppForm
{...register('redirect_uri')}
id='app_redirect_uri'
label={translate({ message: 'Redirect URL' })}
placeholder={translate({ message: 'Redirect URL' })}
placeholder={translate({ message: '*Redirect URL (Required)' })}
inputSize='md'
variant='outline'
className='uri_input'
Expand Down
Loading